Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for decoding part of issue #74 #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tobiassodergren
Copy link

Messages containing UTF8 is being decoded by using the functionality found in http://snipplr.com/view.php?codeview&id=31206

@jmesnil
Copy link
Owner

jmesnil commented Nov 21, 2014

Do you have tests that verify the new decoding code?

@tobiassodergren
Copy link
Author

Good point, I'll try to construct one

@jmesnil
Copy link
Owner

jmesnil commented Nov 21, 2014

FIY, you could add them to the https://github.com/jmesnil/stomp-websocket/blob/master/browsertests/unit/frame.js tests which deals with encoding/decoding of STOMP frames.

Thanks!

@tobiassodergren
Copy link
Author

I changed one character in the message.js test, which generated an error before my fix. When the fix is applied, the test passes.

@tobiassodergren
Copy link
Author

I put the unicode test in a separate unit test and added more unicode characters to the fixture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants