Add new missed turn schema #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames, wD_Users, wD_Members and increased webdip version according to DB value
- CD takeovers get excuses (TODO: Handling of takeovers from members who left before) - Adjusted old NMR code to count missed phases even before adjudication (if an NMR happened, the game will not be progressed so there is no need to do it after the processing in case of a crash) and to reset it if no NMR happened; removed code to reset the count when the member returns to the game (the mere purpose of this count is now to notify other members about the NMR) - Small fixes to get the last commit actually running
Members with no complete set of orders lose an excuse. If no excuses are left, members go into CD. The phase only progesses if there are orders from each country, that has to order. Members are notified about phase extensions and use up of excuses. TODO: Further handling of CDs that goes beyond the current state (temp ban etc). Code can be directly added to Member->setLeft
Basic implementation of new NMR schema
…ble for system temp bans (for new NMR schema)
- A left position does not hold up the game. - Left positions are now handled correctly. - Temp Ban sanctions are now added for missed turns without excuses. Methods for updating MissedTurnCounts during NMR recording added. Though I am not completely sure what data should be stored there so I left them commented.
Web dip missed turn schema
jmo1121109
pushed a commit
that referenced
this pull request
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to see merge conflicts