Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron CI fix #127

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Electron CI fix #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6d186a
Try mac-os 12
jmrossy Dec 8, 2023
ef36602
Try macos-13
jmrossy Dec 8, 2023
70e72fe
Try electron builder v23
jmrossy Dec 8, 2023
b971b4a
Revert "Try electron builder v23"
jmrossy Dec 8, 2023
c6f51f4
Try node 16
jmrossy Dec 8, 2023
d1c1398
Skip use-latest node check
jmrossy Dec 8, 2023
e760bdd
Try node 18
jmrossy Dec 8, 2023
7c74edf
Revert "Revert "Try electron builder v23""
jmrossy Dec 8, 2023
6a6f5aa
Try node 14 + macos12
jmrossy Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/bundle-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [macos-11, windows-2019, ubuntu-latest]
os: [macos-12, windows-2019, ubuntu-latest]

steps:
- uses: actions/checkout@v2

- uses: actions/setup-node@v2
with:
node-version: '14'
check-latest: true

- name: Install dependencies
run: yarn --immutable
Expand All @@ -44,8 +44,6 @@ jobs:
env:
CSC_LINK: ${{ secrets.MAC_CSC_LINK2 }}
CSC_KEY_PASSWORD: ${{ secrets.MAC_CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
if: runner.os == 'macOS'

- name: Build on Windows
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"copy-webpack-plugin": "^10.2.4",
"css-loader": "^6.6.0",
"electron": "^17.4.11",
"electron-builder": "^22.14.13",
"electron-builder": "23.6.0",
"electron-notarize": "^1.1.1",
"eslint": "^8.10.0",
"eslint-plugin-import": "^2.25.4",
Expand Down
Loading
Loading