Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mirror list files for apt #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use mirror list files for apt #475

wants to merge 1 commit into from

Conversation

laurelmay
Copy link
Member

@laurelmay laurelmay commented Aug 29, 2021 •
edited
Loading

This uses the apt lock workaround to replace an ignore_errors on update.

Closes: #446

@laurelmay
Copy link
Member Author

This is in draft until I have a chance to test it.

@laurelmay laurelmay marked this pull request as ready for review August 29, 2021 01:45
@laurelmay
Copy link
Member Author

Validated on Ubuntu 20.04 ARM64

@ripleymj
Copy link
Member

I think the apt ignore failures was put in to handle when the CS mirror is down/unavailable. I tried putting mirror.cs.jmu.edu in /etc/hosts to simulate a failure, and Ansible refuses to proceed, even though the upstream mirror is a very viable choice.

@laurelmay
Copy link
Member Author

So to be clear, the apt cache is still being properly updated for the upstream Mint/Ubuntu repos? If mirror.cs.jmu.edu was down, would an install still successfully pull from the upstream repo? Basically, are we actually helping things along here or are we delaying a failure?

@ripleymj
Copy link
Member

ripleymj commented Sep 1, 2021

Confirmed, an installation will complete as long as there's a viable mirror. I'd prefer we maintain this behavior.

@laurelmay laurelmay force-pushed the ansible-lint branch 2 times, most recently from 50d52cc to 2b3eb58 Compare September 6, 2021 13:42
@laurelmay
Copy link
Member Author

mirror:// mostly works except for a message in mintupdate that the mirror is unreachable. linuxmint/mintupdate#701 exists to try to help with that but we'll likely either need another solution or to just hold off until we can confirm better compatibility with mintupdate.

mtwebster pushed a commit to linuxmint/mintupdate that referenced this pull request Sep 16, 2021
@laurelmay
Avoid unreachable message for non-HTTP mirrors (#701)
e2ab582 
When using a scheme for a mirror that is not HTTP, such as ftp:,
mirror:, or file:, mintupdate reports a message that the mirror cannot
be reached. In actuality, the mirror very well may be reachable but it
cannot check that using an HTTP request. Rather than trying to implement
support for all the protocols in sources.list(5), this skips the check
for any mirror_url that doesn't start with `http`.


ref: jmunixusers/cs-vm-build#475
@laurelmay
Copy link
Member Author

Alright and I think this one is actually ready for review too. Tested by just blocking 134.126.0.0/16. It took a second to timeout but it eventually figured itself out, ignored the "down" mirror, and proceeded. No complaints from mintupdate on config format or anything like that.

@laurelmay laurelmay changed the title Resolve ignore-errors lint warnings Use mirror list files for apt Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider apt lock handling
2 participants
@laurelmay @ripleymj