Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct class naming for the inspector #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nnseva
Copy link

@nnseva nnseva commented Jan 4, 2015

Doing trick like proposed we are passing correct names to the inspector.

What is not good, I don't know how to check inspector behaviour correctly. Really I've checked it in the browser manually, so you might wish to improve the testcases.

@jneen
Copy link
Owner

jneen commented Jan 4, 2015

This seems intriguing. I'd like to see some performance numbers on it though, since it introduces a string eval, and I'm not sure how that plays with VMs

@nnseva
Copy link
Author

nnseva commented Jan 9, 2015

The string eval may take some performance penalty, but I think it should not affect the production code noticable in this case, because this penalty will aply only to class (metaclass object) creation code, while the instance creation code should not be affected.

@jneen
Copy link
Owner

jneen commented Jan 9, 2015

I believe that's true too, but I would like to see it tested and verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants