Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Papenbrock/1d integral #208

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

christofbradly
Copy link
Collaborator

  • Removed four_oscillator_integral_1D as it was numerically unstable for large arguments.
  • HOCartesianEnergyConservedPerDim now uses four_oscillator_integral_general

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5734214727

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 94.074%

Totals Coverage Status
Change from base Build 5641788895: -0.007%
Covered Lines: 4937
Relevant Lines: 5248

💛 - Coveralls

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmarks:
  • Target: 2 Aug 2023 - 03:15
  • Baseline: 2 Aug 2023 - 03:27
  • Package commits:
  • Target: d3864e
  • Baseline: db528b
  • Julia commits:
  • Target: e4ee48
  • Baseline: e4ee48
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["Rimu", "(10, 20) Mom space with projected energy and initiator"] 1.23 (5%) ❌ 1.00 (1%)
["Rimu", "(4+1, 11) 2C Mom space with G2Correlators"] 0.94 (5%) ✅ 1.00 (1%)
["Rimu", "(5+3, 12) Real space fermions in a 4×3 lattice with initiator"] 0.95 (5%) ✅ 1.00 (1%)
["Rimu", "(50, 50) Real space"] 0.88 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu"]

Julia versioninfo

Target

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 5849 s 0 s 422 s 6390 s 0 s
 #2 2294 MHz 6682 s 0 s 382 s 5593 s 0 s
 Memory: 6.7694854736328125 GB (5271.32421875 MB free)
 Uptime: 1276.63 sec
 Load Avg: 1.14 1.1 0.95
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 5936 s 0 s 555 s 13448 s 0 s
 #2 2294 MHz 13887 s 0 s 404 s 5651 s 0 s
 Memory: 6.7694854736328125 GB (5203.9609375 MB free)
 Uptime: 2007.23 sec
 Load Avg: 1.04 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmark: 2 Aug 2023 - 3:15
  • Package commit: d3864e
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["Rimu", "(10, 20) Mom space with projected energy and initiator"] 41.718 s (5%) 17.087 ms 21.34 MiB (1%) 486390
["Rimu", "(4+1, 11) 2C Mom space with G2Correlators"] 36.549 s (5%) 27.719 ms 23.21 MiB (1%) 638706
["Rimu", "(5+3, 12) Real space fermions in a 4×3 lattice with initiator"] 39.452 s (5%) 21.194 ms 55.75 MiB (1%) 1653900
["Rimu", "(50, 50) Real space"] 75.920 s (5%) 29.446 ms 31.43 MiB (1%) 210776

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu"]

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 5849 s 0 s 422 s 6390 s 0 s
 #2 2294 MHz 6682 s 0 s 382 s 5593 s 0 s
 Memory: 6.7694854736328125 GB (5271.32421875 MB free)
 Uptime: 1276.63 sec
 Load Avg: 1.14 1.1 0.95
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmark: 2 Aug 2023 - 3:27
  • Package commit: db528b
  • Julia commit: e4ee48
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["Rimu", "(10, 20) Mom space with projected energy and initiator"] 34.001 s (5%) 29.200 ms 21.34 MiB (1%) 486440
["Rimu", "(4+1, 11) 2C Mom space with G2Correlators"] 38.995 s (5%) 39.722 ms 23.21 MiB (1%) 638718
["Rimu", "(5+3, 12) Real space fermions in a 4×3 lattice with initiator"] 41.536 s (5%) 7.193 ms 55.75 MiB (1%) 1653901
["Rimu", "(50, 50) Real space"] 85.837 s (5%) 35.402 ms 31.43 MiB (1%) 210757

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu"]

Julia versioninfo

Julia Version 1.9.2
Commit e4ee485e909 (2023-07-05 09:39 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
 speed user nice sys idle irq
 #1 2294 MHz 5936 s 0 s 555 s 13448 s 0 s
 #2 2294 MHz 13887 s 0 s 404 s 5651 s 0 s
 Memory: 6.7694854736328125 GB (5203.9609375 MB free)
 Uptime: 2007.23 sec
 Load Avg: 1.04 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, broadwell)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU family: 6
Model: 79
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4589.37
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 512 KiB (2 instances)
L3 cache: 50 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Copy link
Collaborator

@mtsch mtsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Owner

@joachimbrand joachimbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@christofbradly christofbradly merged commit 8f91d7d into develop Aug 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants