Pass scalaVersion to Scalafix as needed for Scalafix 0.13.0
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
approved these changes
Sep 30, 2024
| @@ -63,6 +66,7 @@ object ScalafixModule { | |||
| os.pwd | |||
| ) | |||
|
|
|||
| @nowarn("msg=parameter scalaBinaryVersion in method fixAction is never used") | |||
There was a problem hiding this comment.
I assume you left the parameter for binary compatibility in the patch line? Nitpicking: we could create an overload (easier to clear later) and get rid of the propagation of scalafixScalaBinaryVersion for the real code path.
bjaglin
reviewed
Sep 30, 2024
Comment on lines
+61
to
+64
| PathRef(sources().head.path / "fix-2.12") -> Seq( | ||
| TestInvocation.Targets(Seq("__.fix")), | ||
| TestInvocation.Targets(Seq("verify")) | ||
| ), |
There was a problem hiding this comment.
I just saw tests were failing because of that boyscout-rule addition, independently of the actual purpose of this PR 🤔
There was a problem hiding this comment.
The tests were not running. I could do this in a separate PR but honestly I don't see the reason.
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
bjaglin
approved these changes
Sep 30, 2024
lolgab
changed the title
scalaVersion to Scalafix as needed for Scalafix 0.13.0
lolgab
changed the title
scalaVersion to Scalafix as needed for Scalafix 0.13.0scalaVersion to Scalafix as needed for Scalafix 0.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalafixScalaBinaryVersionin favor ofscalaVersionfixActionoverloads which take scalaBinaryVersion as a parameterPull Request: #205