feat: add golangci-lint #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhthomas
force-pushed
the
160
branch
4 times, most recently
from
6392c4e
to
376db83
Compare
This comment was marked as resolved.
This comment was marked as resolved.
uhthomas
force-pushed
the
160
branch
3 times, most recently
from
0ca8176
to
362d828
Compare
uhthomas
force-pushed
the
160
branch
3 times, most recently
from
be9479c
to
2b43235
Compare
|
@jodevsa Would it be possible to merge this soon? Now? It looks like a lot of changes are being made and it would be great to prevent potential issues! |
|
Hey @uhthomas I am willing to take on this with you. Checked the PR and it looks good, do you mind resolving the conflict, so we can merge this? |
|
🎉 This issue has been resolved in version 2.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint runs many analysers, including staticcheck, which prevent correctness issues and catch bugs.
https://golangci-lint.run/
Fixes: #160