Deny #1
Open
Deny #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Always include a .gitignore file in all of your projects. You can base it off of this one: https://github.com/SDiamante13/music-friends-backend/blob/main/.gitignore |
SDiamante13
suggested changes
May 13, 2022
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
Outdated
Show resolved
Hide resolved
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
Show resolved
Hide resolved
| @GetMapping("/greetUser") | ||
| public String helloUser() { | ||
|
|
||
| return "hello " + userService.helloUser(); |
There was a problem hiding this comment.
The point of this feature was to be able to accept a name and greet that person. You should not hard-code Joe into your app. Have it work for any name the consumer passes to you.
| User user; | ||
|
|
||
|
|
||
| public UserService(User user) { this.user = user; |
There was a problem hiding this comment.
User is a model class that frequently changes so it should not be injected into this class. Instead you would want it to be an input to a method.
| return "Hello My Friend !";} | ||
|
|
||
| public String helloUser() { | ||
| user.setName("Joe"); |
There was a problem hiding this comment.
instead of setting the name to Joe, pass in the name in the method
|
|
||
|
|
||
| class UserServiceTest { | ||
| private UserService userServiceUnderTest; |
There was a problem hiding this comment.
just userService here is clear enough
Suggested change
| private UserService userServiceUnderTest; | |
| private UserService userService; |
| void shouldReturnStringHellowWorld(){ | ||
| //THIS IS FOR J-UNIT 5 JUPITER | ||
| //given | ||
| String hellow="Hello My Friend !"; |
There was a problem hiding this comment.
Choose a better name for the variable. Tests should be easy to understand
Suggested change
| String hellow="Hello My Friend !"; | |
| String expectedMessage="Hello My Friend !"; |
| //given | ||
| String hellow="Hello My Friend !"; | ||
| //when | ||
| String stringValidity =userServiceUnderTest.helloMessage(); |
There was a problem hiding this comment.
Suggested change
| String stringValidity =userServiceUnderTest.helloMessage(); | |
| String actualMessage =userServiceUnderTest.helloMessage(); |
| } | ||
| @Test | ||
| void shouldReturnStringHellowWorldPlusUserName(){ | ||
| user.setName("Joe"); |
There was a problem hiding this comment.
Try applying my advice about passing in the user into the method and try testing this again.
| @RestController | ||
| public class UserMainController { | ||
|
|
||
| @Autowired |
…s/UserService.java Co-authored-by: Steven Diamante <steven4@vt.edu>
|
I have tried to read through the comments,and some have been
understood except the idea about the model class , Autowired thing
and constructor dependence injection iam still trying to grasping
…On Sat, May 14, 2022 at 12:31 AM Steven Diamante ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Great job! You're almost there!
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
<#1 (comment)>
:
> @@ -0,0 +1,51 @@
+package com.Deny.MyMentorProject.Services;
+
+import com.Deny.MyMentorProject.User.User;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
***@***.***
+public class UserService {
+
+ @Autowired
⬇️ Suggested change
- @Autowired
Can remove @Autowired <https://github.com/Autowired> here since you are
using constructor injection below.
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
<#1 (comment)>
:
> +import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
***@***.***
+public class UserService {
+
+ @Autowired
+ User user;
+
+
+ public UserService(User user) { this.user = user;
+ }
+
+
+ public String helloMessage() {
+ return "Hello My Friend !";}
format your code. IntelliJ can do it for you. On Mac, CMD+OPTION+L. On
Windows, CTRL+ALT+L.
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Controllers/UserMainController.java
<#1 (comment)>
:
> +UserService userService;
+
+ public UserMainController(UserService userService) {
+ this.userService = userService;
+ }
+
+ @GetMapping
+ public String helloMessage() {
+
+ return userService. helloMessage();
+ }
+
+ @GetMapping("/greetUser")
+ public String helloUser() {
+
+ return "hello " + userService.helloUser();
The point of this feature was to be able to accept a name and greet that
person. You should not hard-code Joe into your app. Have it work for any
name the consumer passes to you.
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
<#1 (comment)>
:
> @@ -0,0 +1,51 @@
+package com.Deny.MyMentorProject.Services;
+
+import com.Deny.MyMentorProject.User.User;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
***@***.***
+public class UserService {
+
+ @Autowired
+ User user;
+
+
+ public UserService(User user) { this.user = user;
User is a model class that frequently changes so it should not be injected
into this class. Instead you would want it to be an input to a method.
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
<#1 (comment)>
:
> ***@***.***
+public class UserService {
+
+ @Autowired
+ User user;
+
+
+ public UserService(User user) { this.user = user;
+ }
+
+
+ public String helloMessage() {
+ return "Hello My Friend !";}
+
+ public String helloUser() {
+ user.setName("Joe");
instead of setting the name to Joe, pass in the name in the method
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Services/UserService.java
<#1 (comment)>
:
> + public UserService(User user) { this.user = user;
+ }
+
+
+ public String helloMessage() {
+ return "Hello My Friend !";}
+
+ public String helloUser() {
+ user.setName("Joe");
+ return "hello " + user.getName();
+ }
+ public String messageToReTurn(String messagerequest) {
+
+ String reply = "";
+
+ if (messagerequest ==""){
Feature 3 should be a random greeting. You can create a list of the
statements below and call a randomIndex using java.util.Random.
Hello {User}!
Hey {User}, nice to see you here!
{User} welcome back!
Have a splendid day {User}.
------------------------------
In MyMentorProject/src/main/java/com/Deny/MyMentorProject/User/User.java
<#1 (comment)>
:
> @@ -0,0 +1,49 @@
+package com.Deny.MyMentorProject.User;
+
+
+import org.springframework.stereotype.Service;
+
***@***.***
Remove this as User is constantly changing. Only classes which are
stateless should be initialized as a Spring Bean.
------------------------------
In MyMentorProject/src/main/java/com/Deny/MyMentorProject/User/User.java
<#1 (comment)>
:
> @@ -0,0 +1,49 @@
+package com.Deny.MyMentorProject.User;
+
+
+import org.springframework.stereotype.Service;
+
***@***.***
+public class User {
+
+ private Long id;
+
+ public void setName(String name) {
+ this.name = name;
+ }
+
+ private String name;
Format your code and define your variables first, then the constructors,
then getters and setters, then equals and hash code and toString
------------------------------
In
MyMentorProject/src/test/java/com/Deny/MyMentorProject/Services/UserServiceTest.java
<#1 (comment)>
:
> @@ -0,0 +1,43 @@
+package com.Deny.MyMentorProject.Services;
+
+import com.Deny.MyMentorProject.User.User;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+
+class UserServiceTest {
+ private UserService userServiceUnderTest;
just userService here is clear enough
⬇️ Suggested change
- private UserService userServiceUnderTest;
+ private UserService userService;
------------------------------
In
MyMentorProject/src/test/java/com/Deny/MyMentorProject/Services/UserServiceTest.java
<#1 (comment)>
:
> +
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+
+class UserServiceTest {
+ private UserService userServiceUnderTest;
+ private User user;
+ @beforeeach
+ void setUp() {
+ userServiceUnderTest=new UserService(user);
+ }
***@***.***
+ void shouldReturnStringHellowWorld(){
+//THIS IS FOR J-UNIT 5 JUPITER
+ //given
+ String hellow="Hello My Friend !";
Choose a better name for the variable. Tests should be easy to understand
⬇️ Suggested change
- String hellow="Hello My Friend !";
+ String expectedMessage="Hello My Friend !";
------------------------------
In
MyMentorProject/src/test/java/com/Deny/MyMentorProject/Services/UserServiceTest.java
<#1 (comment)>
:
> +
+
+class UserServiceTest {
+ private UserService userServiceUnderTest;
+ private User user;
+ @beforeeach
+ void setUp() {
+ userServiceUnderTest=new UserService(user);
+ }
***@***.***
+ void shouldReturnStringHellowWorld(){
+//THIS IS FOR J-UNIT 5 JUPITER
+ //given
+ String hellow="Hello My Friend !";
+ //when
+ String stringValidity =userServiceUnderTest.helloMessage();
⬇️ Suggested change
- String stringValidity =userServiceUnderTest.helloMessage();
+ String actualMessage =userServiceUnderTest.helloMessage();
------------------------------
In
MyMentorProject/src/test/java/com/Deny/MyMentorProject/Services/UserServiceTest.java
<#1 (comment)>
:
> + userServiceUnderTest=new UserService(user);
+ }
***@***.***
+ void shouldReturnStringHellowWorld(){
+//THIS IS FOR J-UNIT 5 JUPITER
+ //given
+ String hellow="Hello My Friend !";
+ //when
+ String stringValidity =userServiceUnderTest.helloMessage();
+ //then
+ assertEquals(hellow,stringValidity);
+
+ }
+ @test
+ void shouldReturnStringHellowWorldPlusUserName(){
+ user.setName("Joe");
Try applying my advice about passing in the user into the method and try
testing this again.
------------------------------
In
MyMentorProject/src/main/java/com/Deny/MyMentorProject/Controllers/UserMainController.java
<#1 (comment)>
:
> @@ -0,0 +1,39 @@
+package com.Deny.MyMentorProject.Controllers;
+
+import com.Deny.MyMentorProject.Services.UserService;
+import com.Deny.MyMentorProject.User.User;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.web.bind.annotation.GetMapping;
+
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RestController;
+
***@***.***
+public class UserMainController {
+
+ @Autowired
⬇️ Suggested change
- @Autowired
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWXFZCHBW5XQBA45NPTUYYTVJ3C4LANCNFSM5V3SZNCQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two features worked as per the readme and i tried to attempt feature three , and only one test passed