Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main dts mtl merge 2 #1

Closed
wants to merge 7 commits into from
Closed

Main dts mtl merge 2 #1

wants to merge 7 commits into from

Conversation

joechengxperi
Copy link
Owner

No description provided.

@macchian
Copy link

@joechengxperi I think all changes in dts.c could be a single commit.
describe the code modification in comments.

@joechengxperi
Copy link
Owner Author

@joechengxperi I think all changes in dts.c could be a single commit. describe the code modification in comments.

@macchian I just pushed the merged commit. Please check.

macchian
macchian reviewed Oct 24, 2023
View reviewed changes
src/include/sof/audio/dts/DtsSofInterfaceVersion.h
@@ -8,10 +8,10 @@

#define DTS_SOF_INTERFACE_PRODUCT_NAME "DtsSofInterface"
#define DTS_SOF_INTERFACE_PRODUCT_VERSION_MAJOR 1
#define DTS_SOF_INTERFACE_PRODUCT_VERSION_MINOR 0
#define DTS_SOF_INTERFACE_PRODUCT_VERSION_PATCH 7
#define DTS_SOF_INTERFACE_PRODUCT_VERSION_MINOR 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit could merge into dts : add require changes for MTL
Because it takes effect when commit dts : add require changes for MTL merge.

macchian
macchian reviewed Oct 24, 2023
View reviewed changes
Copy link

@macchian macchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest change title "fix DTS support on IPC4" or more specific description

@joechengxperi
dts : add LOG_MODULE_REGISTER()
9074a05 
It would build fail without LOG_MODULE_REGISTER.

Co-developed-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi joechengxperi force-pushed the main-dts-mtl-merge-2 branch 2 times, most recently from de8db87 to 694aeb6 Compare October 26, 2023 09:47
@joechengxperi
dts : fix set_configuration() fail on MTL
d0b1e70 
md->state is set in IPC3, not in IPC4.

set_configuration() would fail on MTL because md->state is not set.

Add macro CONFIG_IPC_MAJOR_3 to avoid this problem.

Co-developed-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi
dts : add more error logs in set_configuration()
f07d601 
Add more error logs to identify potential problem in set_configuration()

Co-developed-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi
dts : update DTS version to V1.1.3
8bb4a05 
MTL support is added in DTS V1.1.3.

Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi joechengxperi force-pushed the main-dts-mtl-merge-2 branch 2 times, most recently from 47822aa to f41e4fb Compare October 31, 2023 07:38
@joechengxperi
audio : dts : add DTS support for MTL
04991be 
Add DTS init function

Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi
zephyr : import dts library
7d5cc30 
Importing DTS library here to ensure DTS library is built into SOF
firmware as a static library.

Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
@joechengxperi
app: overlays: Add DTS support to MTL
ac2f487 
This patch adds DTS_CODEC for IPC4 Intel platform builds.

Since EQ IIR + DTS is the combination we use to support customer, adding
EQ IIR here to ensure it's enabled.

Signed-off-by: Joe Cheng <joe.cheng@xperi.com>
joechengxperi pushed a commit that referenced this pull request Mar 22, 2024
@marc-hb @lgirdwood
zephyr/wrapper.c: dereference NULL in POSIX for better k_panic() trace
884305b 
As discussed in the alternative approach
zephyrproject-rtos/zephyr#68494, k_panic() in
POSIX mode has various shortcomings that do not provide a useful
trace. Useless pointers to signal handlers or other cleanup routines are
printed instead. Leverage our already existing
k_sys_fatal_error_handler() and dereference a NULL pointer there when in
POSIX mode. This "fails fast" and provides a complete and relevant stack
trace in CI when fuzzing or when using some other static
analyzer. Example of how fuzzing failure thesofproject#8832 would have looked like in
CI results thanks to this commit:

```
./build-fuzz/zephyr/zephyr.exe: Running 1 inputs 1 time(s) each.
Running: ./rballoc_align_fuzz_crash
*** Booting Zephyr OS build zephyr-v3.5.0-3971-ge07de4e0a167 ***
[00:00:00.000,000] <inf> main: SOF on native_posix
[00:00:00.000,000] <inf> main: SOF initialized
@ WEST_TOPDIR/sof/zephyr/lib/alloc.c:391
[00:00:00.000,000] <err> os: >>> ZEPHYR FATAL ERROR 4: Kernel panic
[00:00:00.000,000] <err> os: Current thread: 0x891f8a0 (unknown)
[00:00:00.000,000] <err> zephyr: Halting emulation
AddressSanitizer:DEADLYSIGNAL
=================================================================
==1784402==ERROR: AddressSanitizer: SEGV on unknown address 0x00000000
==1784402==The signal is caused by a WRITE memory access.
==1784402==Hint: address points to the zero page.
    #0 0x829a77d in k_sys_fatal_error_handler zephyr/wrapper.c:352:19
    #1 0x829b8c0 in rballoc_align zephyr/lib/alloc.c:391:3
    #2 0x8281438 in buffer_alloc src/audio/buffer.c:58:16
    #3 0x826a60a in buffer_new src/ipc/ipc-helper.c:48:11
    #4 0x8262107 in ipc_buffer_new src/ipc/ipc3/helper.c:459:11
    #5 0x825944d in ipc_glb_tplg_buffer_new src/ipc/ipc3/handler.c:1305:8
    #6 0x8257036 in ipc_cmd src/ipc/ipc3/handler.c:1651:9
    thesofproject#7 0x8272e59 in ipc_platform_do_cmd src/platform/posix/ipc.c:162:2
    thesofproject#8 0x826a2ac in ipc_do_cmd src/ipc/ipc-common.c:328:9
    thesofproject#9 0x829b0ab in task_run zephyr/include/rtos/task.h:94:9
    thesofproject#10 0x829abd8 in edf_work_handler zephyr/edf_schedule.c:32:16
    thesofproject#11 0x83560f7 in work_queue_main zephyr/kernel/work.c:688:3
    thesofproject#12 0x82244c2 in z_thread_entry zephyr/lib/os/thread_entry.c:48:2
```

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchian macchian macchian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joechengxperi @macchian