Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to log all failed parameter sets to a file #135

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

joezuntz
Copy link
Owner

The hard part here is making this work under MPI without garbling the output. We use the MPI.File feature to do so, which seems to work, but should be considered experimental for a while until it has been tested at scale.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.

Project coverage is 59.97%. Comparing base (4574989) to head (5e19527).

Files Patch % Lines
cosmosis/runtime/mpi_pool.py 65.38% 9 Missing ⚠️
cosmosis/main.py 42.85% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   59.81%   59.97%   +0.15%     
==========================================
  Files         117      117              
  Lines       12248    12309      +61     
==========================================
+ Hits         7326     7382      +56     
- Misses       4922     4927       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joezuntz joezuntz merged commit ae1b65c into main Jul 25, 2024
14 checks passed
@joezuntz joezuntz deleted the failure-log branch July 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants