Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pocomc.Prior object to use a global Pipeline variabkle #137

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

joezuntz
Copy link
Owner

Addresses issue #136

Currently the prior object cosmosis gives to PocoMC includes a reference to the complete pipeline object. If this fails to pickle then the PocoMC save state process fails too.

This changes things to use a global pipeline variable instead, which already existed because the sampler MPI needed it.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.96%. Comparing base (4574989) to head (921caa7).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   59.81%   59.96%   +0.15%     
==========================================
  Files         117      117              
  Lines       12248    12308      +60     
==========================================
+ Hits         7326     7381      +55     
- Misses       4922     4927       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joezuntz joezuntz merged commit daa33a8 into main Jul 26, 2024
14 checks passed
@joezuntz joezuntz deleted the fix-poco-pickling branch July 26, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants