Skip to content

Commit

Permalink
v2.7
Browse files Browse the repository at this point in the history
  • Loading branch information
johannes-schliephake committed Sep 15, 2023
2 parents d214206 + 44a194a commit 99722c7
Show file tree
Hide file tree
Showing 352 changed files with 10,764 additions and 2,650 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.DS_Store
xcuserdata/
fastlane/Preview.html
fastlane/report.xml
fastlane/screenshots/screenshots.html
fastlane/test_output
fastlane/tmp
xcuserdata/
74 changes: 57 additions & 17 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
@@ -1,41 +1,81 @@
disabled_rules:
- closure_parameter_position
- cyclomatic_complexity
- file_length
- function_body_length
- function_parameter_count
- line_length
- function_body_length
- orphaned_doc_comment
- redundant_discardable_let
- statement_position
- type_body_length
- file_length
- vertical_whitespace
- cyclomatic_complexity
- statement_position
- closure_parameter_position
- orphaned_doc_comment

opt_in_rules:
- file_types_order
- overridden_super_call
- anonymous_argument_in_multiline_closure
- array_init
- closure_spacing
- contains_over_filter_count
- contains_over_filter_is_empty
- contains_over_first_not_nil
- contains_over_range_nil_comparison
- contains_over_filter_count
- first_where
- last_where
- convenience_type
- empty_collection_literal
- empty_count
- empty_string
- convenience_type
- closure_spacing
- empty_xctest_method
- extension_access_modifier
- fatal_error_message
- file_name
- file_name_no_space
- file_types_order
- first_where
- flatmap_over_map_reduce
- implicit_return
- implicitly_unwrapped_optional
- last_where
- legacy_multiple
- operator_usage_whitespace
- overridden_super_call
- prefer_nimble
- prefer_self_in_static_references
- prefixed_toplevel_constant
- prohibited_interface_builder
- redundant_type_annotation
- shorthand_optional_binding
- single_test_class
- sorted_first_last
- static_operator
- toggle_bool
- unneeded_parentheses_in_closure_argument
- unowned_variable_capture
- unused_capture_list
- yoda_condition

custom_rules:
print:
included: ".*\\.swift"
name: "Print"
regex: "((\\bprint)|(Swift\\.print))\\s*\\("
message: "Prints should be removed"
included: '.*\.swift'
name: 'Print'
regex: '\b(Swift\s*\.\s*)?print\b'
message: 'Prints should be removed'
severity: warning
view_model_state_access:
included: '.*\.swift'
name: 'ViewModel State Access'
regex: '\bviewModel\s*\.\s*state'
message: 'ViewModel state should be accessed via subscript'
severity: warning
test_naming:
included: '.*Tests\.swift'
name: 'Test Naming'
regex: '\bfunc\s+test(?![a-zA-Z0-9]+(_given[a-zA-Z0-9]+)?(_when[a-zA-Z0-9]+)?_then[a-zA-Z0-9]+\s*\(\))'
message: 'Tests should be named "testFunction_givenX_whenY_thenZ", with "given" and "when" being optional'
severity: warning
fatal_error:
included: '.*\.swift'
name: 'Fatal Error'
regex: '\b(Swift\s*\.\s*)?fatalError\b'
message: 'Fatal errors should be removed'
severity: warning

excluded:
Expand Down
6 changes: 6 additions & 0 deletions App/PasswordsApp.swift
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import SwiftUI
import Factory


@main struct PasswordsApp: App {

@StateObject private var autoFillController = Configuration.isTestEnvironment ? AutoFillController.mock : AutoFillController.default

init() {
_ = resolve(\.logger)
_ = resolve(\.windowSizeService)
}

// MARK: Views

var body: some Scene {
Expand Down
19 changes: 19 additions & 0 deletions Extension/ExtensionViewController.swift
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
import SwiftUI
import Factory
import UniformTypeIdentifiers


class ExtensionViewController: UIViewController {

override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
_ = resolve(\.logger)
_ = resolve(\.windowSizeService)

super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
}

required init?(coder: NSCoder) {
fatalError("init(coder:) has not been implemented") // swiftlint:disable:this fatal_error
}

override func viewDidLoad() {
super.viewDidLoad()
Expand Down Expand Up @@ -78,12 +90,19 @@ class ExtensionViewController: UIViewController {
super.viewDidAppear(animated)

NotificationCenter.default.post(name: UIApplication.didBecomeActiveNotification, object: nil)
NotificationCenter.default.post(name: UIScene.didActivateNotification, object: view.window?.windowScene)
}

override func viewWillDisappear(_ animated: Bool) {
super.viewWillDisappear(animated)

NotificationCenter.default.post(name: UIApplication.willResignActiveNotification, object: nil)
}

override func viewDidDisappear(_ animated: Bool) {
super.viewDidDisappear(animated)

NotificationCenter.default.post(name: UIApplication.didEnterBackgroundNotification, object: nil)
}

}
50 changes: 24 additions & 26 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@ GEM
specs:
CFPropertyList (3.0.6)
rexml
addressable (2.8.1)
addressable (2.8.5)
public_suffix (>= 2.0.2, < 6.0)
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.2.0)
aws-partitions (1.739.0)
aws-sdk-core (3.171.0)
aws-partitions (1.820.0)
aws-sdk-core (3.181.0)
aws-eventstream (~> 1, >= 1.0.2)
aws-partitions (~> 1, >= 1.651.0)
aws-sigv4 (~> 1.5)
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.63.0)
aws-sdk-core (~> 3, >= 3.165.0)
aws-sdk-kms (1.71.0)
aws-sdk-core (~> 3, >= 3.177.0)
aws-sigv4 (~> 1.1)
aws-sdk-s3 (1.120.0)
aws-sdk-core (~> 3, >= 3.165.0)
aws-sdk-s3 (1.134.0)
aws-sdk-core (~> 3, >= 3.181.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.4)
aws-sigv4 (1.5.2)
aws-sigv4 (~> 1.6)
aws-sigv4 (1.6.0)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
claide (1.1.0)
Expand All @@ -30,13 +30,13 @@ GEM
commander (4.6.0)
highline (~> 2.0.0)
declarative (0.0.20)
digest-crc (0.6.4)
digest-crc (0.6.5)
rake (>= 12.0.0, < 14.0.0)
domain_name (0.5.20190701)
unf (>= 0.0.5, < 1.0.0)
dotenv (2.8.1)
emoji_regex (3.2.3)
excon (0.99.0)
excon (0.102.0)
faraday (1.10.3)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
Expand Down Expand Up @@ -65,8 +65,8 @@ GEM
faraday-retry (1.0.3)
faraday_middleware (1.2.0)
faraday (~> 1.0)
fastimage (2.2.6)
fastlane (2.212.1)
fastimage (2.2.7)
fastlane (2.214.0)
CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.8, < 3.0.0)
artifactory (~> 3.0)
Expand All @@ -90,7 +90,7 @@ GEM
json (< 3.0.0)
jwt (>= 2.1.0, < 3)
mini_magick (>= 4.9.4, < 5.0.0)
multipart-post (~> 2.0.0)
multipart-post (>= 2.0.0, < 3.0.0)
naturally (~> 2.2)
optparse (~> 0.1.1)
plist (>= 3.1.0, < 4.0.0)
Expand All @@ -105,11 +105,11 @@ GEM
xcodeproj (>= 1.13.0, < 2.0.0)
xcpretty (~> 0.3.0)
xcpretty-travis-formatter (>= 0.0.3)
fastlane-plugin-versioning (0.5.1)
fastlane-plugin-versioning (0.5.2)
gh_inspector (1.1.3)
google-apis-androidpublisher_v3 (0.37.0)
google-apis-androidpublisher_v3 (0.49.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-core (0.11.0)
google-apis-core (0.11.1)
addressable (~> 2.5, >= 2.5.1)
googleauth (>= 0.16.2, < 2.a)
httpclient (>= 2.8.1, < 3.a)
Expand Down Expand Up @@ -138,10 +138,9 @@ GEM
google-cloud-core (~> 1.6)
googleauth (>= 0.16.2, < 2.a)
mini_mime (~> 1.0)
googleauth (1.5.0)
googleauth (1.8.0)
faraday (>= 0.17.3, < 3.a)
jwt (>= 1.4, < 3.0)
memoist (~> 0.16)
multi_json (~> 1.11)
os (>= 0.9, < 2.0)
signet (>= 0.16, < 2.a)
Expand All @@ -151,30 +150,29 @@ GEM
httpclient (2.8.3)
jmespath (1.6.2)
json (2.6.3)
jwt (2.7.0)
memoist (0.16.2)
jwt (2.7.1)
mini_magick (4.12.0)
mini_mime (1.1.2)
mini_mime (1.1.5)
multi_json (1.15.0)
multipart-post (2.0.0)
multipart-post (2.3.0)
nanaimo (0.3.0)
naturally (2.2.1)
optparse (0.1.1)
os (1.1.4)
plist (3.7.0)
public_suffix (5.0.1)
public_suffix (5.0.3)
rake (13.0.6)
representable (3.2.0)
declarative (< 0.1.0)
trailblazer-option (>= 0.1.1, < 0.2.0)
uber (< 0.2.0)
retriable (3.1.2)
rexml (3.2.5)
rexml (3.2.6)
rouge (2.0.7)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
security (0.1.3)
signet (0.17.0)
signet (0.18.0)
addressable (~> 2.8)
faraday (>= 0.17.5, < 3.a)
jwt (>= 1.5, < 3.0)
Expand Down
22 changes: 0 additions & 22 deletions LogicTests/Info.plist

This file was deleted.

Loading

0 comments on commit 99722c7

Please sign in to comment.