Skip to content

Commit

Permalink
speed up render from 7.8 secs to 7.5
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael Meeks committed Jan 22, 2010
1 parent 063c9e3 commit 8528d9a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions TODO
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
** Bugs:
+ get the -real- CPU counts right [!] ... uh huh ?

+ Ensure that we merge up a sub-process' CPU usage into the
parent process when we hide very short running processes.
+ merge processes for CPU counts:
+ if the ns count is -identical- (and non-zero) it is the same process
+ need to back-merge somehow ?
:-)
+ or can we do this by pid ? [ prolly ! ]

+ fix for profiling a running system ... [ get the origin right ! ]

Expand Down
4 changes: 2 additions & 2 deletions pybootchartgui/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ def _parse_proc_disk_stat_log(file, numCpu):
not sda1, sda2 etc. The format of relevant lines should be:
{major minor name rio rmerge rsect ruse wio wmerge wsect wuse running use aveq}
"""
DISK_REGEX = 'hd.$|sd.$|vd.$'
disk_regex_re = re.compile ('[hsv]d.$')

def is_relevant_line(linetokens):
return len(linetokens) == 14 and re.match(DISK_REGEX, linetokens[2])
return len(linetokens) == 14 and disk_regex_re.match(linetokens[2])

disk_stat_samples = []

Expand Down

0 comments on commit 8528d9a

Please sign in to comment.