Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.metadata for version introspection #94

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Use importlib.metadata for version introspection #94

merged 1 commit into from
Jul 23, 2024

Conversation

duncanmmacleod
Copy link
Contributor

This PR fixes #93 by updating cpnest/__init__.py to use importlib.metadata to discover its own version.

@duncanmmacleod
use importlib.metadata
ce5523f 
for version introspection, closes johnveitch#93
@pep8speaks
Copy link

Hello @duncanmmacleod! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:1: E402 module level import not at top of file

@duncanmmacleod duncanmmacleod mentioned this pull request Jul 23, 2024
Merged
4 tasks
@johnveitch johnveitch merged commit f5a0754 into johnveitch:master Jul 23, 2024
6 checks passed
@duncanmmacleod duncanmmacleod deleted the importlib.metadata branch July 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnveitch johnveitch johnveitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated, use importlib.metadata instead
3 participants
@duncanmmacleod @pep8speaks @johnveitch