Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lyrics__Container instead of Lyrics__Root to skip retrieval of metadata cruft #260

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

thedustyrover
Copy link
Contributor

@thedustyrover thedustyrover commented Aug 11, 2023

Lyrics__Root contains some superfluous elements and renders stuff like:

126 ContributorsTranslationsFrançaisPortuguês

actual lyrics are contained only in Lyrics__Container, of which there can be several. This retrieves all of those and concats them together.

Previous result with lyrics root (New Romantics by Taylor Swift):

126 ContributorsTranslationsFrançaisPortuguêsNew Romantics Lyrics[Verse 1]
We're all bored, we're all so tired of everything
We wait for trains that just aren't coming
We show off our different scarlet letters
Trust me, mine is better
We're so young, but we're on the road to ruin
We play dumb, but we know exactly what we're doing
We cry tears of mascara in the bathroom
Honey, life is just a classroom
(Ah, ah, ah, ah, ah, ah)

[Chorus]
'Cause baby, I could build a castle
Out of all the bricks they threw at me
And every day is like a battle
But every night with us is like a dream
Baby, we're the new romantics
Come on, come along with me
Heartbreak is the national anthem
We sing it proudly
We are too busy dancing
To get knocked off our feet
Baby, we're the new romantics
The best people in life are free

[Verse 2]
We're all here, the lights and noise are blinding
We hang back, it's all in the timing
It's poker, he can't see it in my face
But I'm about to play my Ace (Ahh)
We need love, but all we want is danger
We team up, then switch sides like a record changer
The rumors are terrible and cruel
But, honey, most of them are true
(Ah, ah, ah, ah, ah, ah)
See Taylor Swift LiveGet tickets as low as $113You might also like[Chorus]
'Cause baby, I could build a castle
Out of all the bricks they threw at me
And every day is like a battle (Every day is like a battle)
But every night with us is like a dream
Baby, we're the new romantics
Come on, come along with me
Heartbreak is the national anthem
We sing it proudly
We are too busy dancing (Yeah)
To get knocked off our feet (Hey!)
Baby, we're the new romantics
The best people in life are free

[Post-Chorus]
(Oh, oh, oh-oh, oh)
Oh-oh
(Oh, oh, oh-oh, oh)
So, come on, come along with me
(Oh, oh, oh-oh, oh)
The best people in life are free
(Oh, oh, oh-oh, oh)

[Bridge]
Please, take my hand and
Please, take me dancing and
Please, leave me stranded
It's so romantic (It's so romantic)
(Ah, ah, ah, ah, ah, ah)
[Chorus]
'Cause baby, I could build a castle (Oh, baby, I could build a castle)
Out of all the bricks they threw at me (At me)
And every day is like a battle (Oh-oh-oh-oh-oh)
But every night with us is like a dream (Like a dream)
'Cause baby, I could build a castle (Castle)
Out of all the bricks they threw at me
And every day is like a battle (And every day is like a battle)
But every night with us is like a dream
Baby, we're the new romantics (Ah, ah, ah, ah, ah)
Come on, come along with me
Heartbreak is the national anthem (Ah, ah, ah, ah, ah)
We sing it proudly
We are too busy dancing (Ah, ah, ah, ah, ah)
To get knocked off our feet
Baby, we're the new romantics (Ah, ah, ah, ah, ah)
The best people in life are free211Embed

after code change with lyrics containers:

[Verse 1]
We're all bored, we're all so tired of everything
We wait for trains that just aren't coming
We show off our different scarlet letters
Trust me, mine is better
We're so young, but we're on the road to ruin
We play dumb, but we know exactly what we're doing
We cry tears of mascara in the bathroom
Honey, life is just a classroom
(Ah, ah, ah, ah, ah, ah)

[Chorus]
'Cause baby, I could build a castle
Out of all the bricks they threw at me
And every day is like a battle
But every night with us is like a dream
Baby, we're the new romantics
Come on, come along with me
Heartbreak is the national anthem
We sing it proudly
We are too busy dancing
To get knocked off our feet
Baby, we're the new romantics
The best people in life are free

[Verse 2]
We're all here, the lights and noise are blinding
We hang back, it's all in the timing
It's poker, he can't see it in my face
But I'm about to play my Ace (Ahh)
We need love, but all we want is danger
We team up, then switch sides like a record changer
The rumors are terrible and cruel
But, honey, most of them are true
(Ah, ah, ah, ah, ah, ah)

[Chorus]
'Cause baby, I could build a castle
Out of all the bricks they threw at me
And every day is like a battle (Every day is like a battle)
But every night with us is like a dream
Baby, we're the new romantics
Come on, come along with me
Heartbreak is the national anthem
We sing it proudly
We are too busy dancing (Yeah)
To get knocked off our feet (Hey!)
Baby, we're the new romantics
The best people in life are free

[Post-Chorus]
(Oh, oh, oh-oh, oh)
Oh-oh
(Oh, oh, oh-oh, oh)
So, come on, come along with me
(Oh, oh, oh-oh, oh)
The best people in life are free
(Oh, oh, oh-oh, oh)

[Bridge]
Please, take my hand and
Please, take me dancing and
Please, leave me stranded
It's so romantic (It's so romantic)
(Ah, ah, ah, ah, ah, ah)

[Chorus]
'Cause baby, I could build a castle (Oh, baby, I could build a castle)
Out of all the bricks they threw at me (At me)
And every day is like a battle (Oh-oh-oh-oh-oh)
But every night with us is like a dream (Like a dream)
'Cause baby, I could build a castle (Castle)
Out of all the bricks they threw at me
And every day is like a battle (And every day is like a battle)
But every night with us is like a dream
Baby, we're the new romantics (Ah, ah, ah, ah, ah)
Come on, come along with me
Heartbreak is the national anthem (Ah, ah, ah, ah, ah)
We sing it proudly
We are too busy dancing (Ah, ah, ah, ah, ah)
To get knocked off our feet
Baby, we're the new romantics (Ah, ah, ah, ah, ah)
The best people in life are free

@allerter allerter merged commit a702f5f into johnwmillr:master Aug 11, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants