Skip to content

Commit

Permalink
Improve accuracy of departments in fr_FR provider postcode (#1852)
Browse files Browse the repository at this point in the history
  • Loading branch information
tonial committed May 3, 2023
1 parent 73fd8ed commit b379d24
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
11 changes: 10 additions & 1 deletion faker/providers/address/fr_FR/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class Provider(AddressProvider):
address_formats = ("{{street_address}}\n{{postcode}} {{city}}",)

building_number_formats = ("%", "%#", "%#", "%#", "%##")
postcode_formats = ("#####",)
countries = (
"Afghanistan",
"Afrique du sud",
Expand Down Expand Up @@ -467,3 +466,13 @@ def department_number(self) -> str:
:example: '59'
"""
return self.department()[0]

def postcode(self) -> str:
"""
Randomly returns a postcode generated from existing french depertment number.
exemple: '33260'
"""
department = self.department_number()
if department in ["2A", "2B"]:
department = "20"
return f"{department}{self.random_number(digits=5 - len(department))}"
11 changes: 11 additions & 0 deletions tests/providers/test_address.py
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,17 @@ def test_department_number(self, faker, num_samples):
assert isinstance(department_number, str)
assert department_number in department_numbers

def test_postcode(self, faker, num_samples):
department_numbers = [dept_num for dept_num, dept_name in FrFrAddressProvider.departments]
for _ in range(num_samples):
postcode = faker.postcode()
assert isinstance(postcode, str)
assert (
postcode[:3] in department_numbers # for 3 digits deparments number
or postcode[:2] == "20" # for Corsica : "2A" or "2B"
or postcode[:2] in department_numbers # any other
)


class TestHeIl:
"""Test he_IL address provider methods"""
Expand Down

0 comments on commit b379d24

Please sign in to comment.