Passport Provider and EN_US Implementation #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linting fixed testing issues caused by string formatting fixed line length linting issues, and import * fixed import* in tests, removed unused variable
fcurella
requested changes
May 8, 2023
| issue_date = self.generator.date_time_between(today - timedelta(days=EXPIRY_YEARS * 365 - 1), today) | ||
| age_issue = (issue_date.date() - birthday).days // 365 | ||
|
|
||
| if age_issue < 16: |
There was a problem hiding this comment.
You're already catching age < 16 in the first case of thisif. I'm not sure how we would end up in this branch here.
There was a problem hiding this comment.
Reworked logic on this, updated to remove unnecessary conditions
… added typing hints
fcurella
requested changes
May 16, 2023
fixed grammar mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Added a passport faking functionality
What was wrong
#1853
Addressed one of the desired functionalities
How this fixes it
This adds a new provider that fakes passport data, specifically numbers, issue and expiry dates, and birthdays