Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for the geo/pl_PL provider #2057

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 5, 2024

What does this change

Fix more errors in geo/pl_PL provider data.

What was wrong

  1. The timezone was specified as Europe/Warszawa which is not a standard iANA timezone name.
  2. The capital city was using English name, inconsistently with other cities.
  3. Some city names were missing diacritics.
  4. A few districts of Warsaw remained on the list.

How this fixes it

  1. Restored Europe/Warsaw as the timezone name.
  2. Renamed the capital to Warszawa.
  3. Added missing diacritics.
  4. Removed the remaining districts.

I've also reported the issues to latitude.to, but given it's autogenerated, I doubts whether they'll be able to fix the data. Overall, it looks like an unreliable source of information.

mgorny and others added 5 commits June 5, 2024 05:51
The standardized timezone name in the database is `Europe/Warsaw`.
All other city names are spelled in Polish rather than English,
so change `Warsaw` to `Warszawa` as well.
Fix typos in Polish city names, particular missing diacritics.
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@fcurella fcurella merged commit 1e61099 into joke2k:master Jun 6, 2024
27 checks passed
@mgorny mgorny deleted the pl-fixes branch June 6, 2024 18:19
@mgorny
Copy link
Contributor Author

mgorny commented Jun 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants