Really run libnotify in tests

jolicode · Apr 29, 2024 · db1ed85 · db1ed85
1 parent e415645
commit db1ed85
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 12 deletions.
diff --git a/tests/Notifier/CliBasedNotifierTestTrait.php b/tests/Notifier/CliBasedNotifierTestTrait.php
@@ -131,11 +131,6 @@ public function testSendThrowsExceptionWhenNotificationHasAnEmptyBody()
         }
     }
 
-    public function getIconDir(): string
-    {
-        return realpath(\dirname(__DIR__) . '/fixtures');
-    }
-
     abstract protected function getExpectedCommandLineForNotification(): string;
 
     abstract protected function getExpectedCommandLineForNotificationWithATitle(): string;

diff --git a/tests/Notifier/LibNotifyNotifierTest.php b/tests/Notifier/LibNotifyNotifierTest.php
@@ -15,9 +15,8 @@
 use Joli\JoliNotif\Notification;
 use Joli\JoliNotif\Notifier;
 use Joli\JoliNotif\Notifier\LibNotifyNotifier;
-use PHPUnit\Framework\TestCase;
 
-class LibNotifyNotifierTest extends TestCase
+class LibNotifyNotifierTest extends NotifierTestCase
 {
     public function testGetPriority()
     {
@@ -46,12 +45,58 @@ public function testInitialize()
             $this->markTestSkipped('Looks like libnotify is not installed');
         }
 
-        $closureToInitialize = \Closure::bind(static function (LibNotifyNotifier $notifier) {
-            $notifier->initialize();
-        }, null, LibNotifyNotifier::class);
-
         $this->assertTrue($notifier->isSupported());
-        $closureToInitialize($notifier);
+    }
+
+    public function testSendThrowsExceptionWhenNotificationDoesntHaveBody()
+    {
+        $notifier = $this->getNotifier();
+
+        $notification = new Notification();
+
+        try {
+            $notifier->send($notification);
+            $this->fail('Expected a InvalidNotificationException');
+        } catch (\Exception $e) {
+            $this->assertInstanceOf('Joli\JoliNotif\Exception\InvalidNotificationException', $e);
+        }
+    }
+
+    public function testSendThrowsExceptionWhenNotificationHasAnEmptyBody()
+    {
+        $notifier = $this->getNotifier();
+
+        $notification = new Notification();
+        $notification->setBody('');
+
+        try {
+            $notifier->send($notification);
+            $this->fail('Expected a InvalidNotificationException');
+        } catch (\Exception $e) {
+            $this->assertInstanceOf('Joli\JoliNotif\Exception\InvalidNotificationException', $e);
+        }
+    }
+
+    public function testSendNotificationWithAllOptions()
+    {
+        $notifier = $this->getNotifier();
+
+        $notification = (new Notification())
+            ->setBody('I\'m the notification body')
+            ->setTitle('I\'m the notification title')
+            ->addOption('subtitle', 'I\'m the notification subtitle')
+            ->addOption('sound', 'Frog')
+            ->addOption('url', 'https://google.com')
+            ->setIcon($this->getIconDir() . '/image.gif')
+        ;
+
+        $result = $notifier->send($notification);
+
+        if (!$result) {
+            $this->markTestSkipped('Notification was not sent');
+        }
+
+        $this->assertTrue($notifier->send($notification));
     }
 
     protected function getNotifier(): LibNotifyNotifier

diff --git a/tests/Notifier/NotifierTestCase.php b/tests/Notifier/NotifierTestCase.php
@@ -18,6 +18,11 @@ abstract class NotifierTestCase extends TestCase
 {
     abstract protected function getNotifier(): Notifier;
 
+    protected function getIconDir(): string
+    {
+        return realpath(\dirname(__DIR__) . '/fixtures');
+    }
+
     /**
      * Call protected/private method of a class.
      *