Remove icon placeholder

jonathanklee · Oct 5, 2024 · 199726f · 199726f
1 parent e02c2d5
commit 199726f
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 23 deletions.
diff --git a/app/src/main/java/com/klee/sapio/ui/view/EvaluationsActivity.kt b/app/src/main/java/com/klee/sapio/ui/view/EvaluationsActivity.kt
@@ -83,8 +83,6 @@ class EvaluationsActivity : AppCompatActivity() {
         mViewModel.iconUrl.observe(this) {
             Glide.with(this.applicationContext)
                 .load(EvaluationService.BASE_URL + it)
-                .placeholder(R.drawable.ic_android)
-                .error(R.drawable.ic_android)
                 .into(mBinding.image)
         }
 
@@ -103,10 +101,6 @@ class EvaluationsActivity : AppCompatActivity() {
             startActivity(intent)
         }
 
-        mBinding.image.setImageDrawable(
-            AppCompatResources.getDrawable(applicationContext, R.drawable.ic_android)
-        )
-
         mViewModel.listEvaluations(packageName)
     }
 

diff --git a/app/src/main/java/com/klee/sapio/ui/view/FeedAppAdapter.kt b/app/src/main/java/com/klee/sapio/ui/view/FeedAppAdapter.kt
@@ -70,17 +70,11 @@ class FeedAppAdapter(
             element.rooted.setBackgroundColor(rootLabel.color)
         }
 
-        holder.binding.image.setImageDrawable(
-            AppCompatResources.getDrawable(mContext, R.drawable.ic_android)
-        )
-
         holder.imageLoadJob = holder.viewHolderScope.launch {
             val icons = mEvaluationRepository.existingIcon("${app.packageName}.png")
             if (icons.isNotEmpty()) {
                 Glide.with(mContext.applicationContext)
                     .load(EvaluationService.BASE_URL + icons[0].url)
-                    .placeholder(R.drawable.ic_android)
-                    .error(R.drawable.ic_android)
                     .into(holder.binding.image)
             }
         }

diff --git a/app/src/main/java/com/klee/sapio/ui/view/SearchAppAdapter.kt b/app/src/main/java/com/klee/sapio/ui/view/SearchAppAdapter.kt
@@ -46,17 +46,11 @@ class SearchAppAdapter(
         element.appName.text = app.name
         element.packageName.text = app.packageName
 
-        holder.binding.image.setImageDrawable(
-            AppCompatResources.getDrawable(mContext, R.drawable.ic_android)
-        )
-
         holder.imageLoadJob = holder.viewHolderScope.launch {
             val icons = mEvaluationRepository.existingIcon("${app.packageName}.png")
             if (icons.isNotEmpty()) {
                 Glide.with(mContext.applicationContext)
                     .load(EvaluationService.BASE_URL + icons[0].url)
-                    .placeholder(R.drawable.ic_android)
-                    .error(R.drawable.ic_android)
                     .into(holder.binding.image)
             }
         }

diff --git a/app/src/main/res/drawable/ic_android.xml b/app/src/main/res/drawable/ic_android.xml