Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer '23 Release (API v58.0) - v4.11.0 #507

Merged
merged 23 commits into from
Jun 29, 2023
Merged

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Jun 6, 2023

Manage Package Changes

One change in this PR that's specific to the manage package: .forceignore has been updated to exclude the new CustomIndex for the field LogEntry__c.OriginLocation__c (added in v4.10.5). The CustomIndex metadata type is considered generally available by Salesforce, but there have been a handful of gack errors reported that are related to the custom index failing to deploy in some orgs. So, as a precaution, the CustomIndex is unfortunately being excluded from the managed package this release to avoid any related upgrade issues - hopefully, the index will be added to the next managed package version, the Winter '24 release.

Core Unlocked Package Changes

Metadata API Version Updated to v58.0

  • Updated all metadata to API v58.0 (Summer '23 release)
  • Updated some picklist values to have options for API v58.0 and 59.0
  • Simplified some Apex calls to String.join() to remove extra conversions of Set<String> to List<String> - Summer '23 now supports iterating over Set<Object>
  • Retrieved the metadata for fields & objects so the repo's version more closely matches the XML returned by the platform

logEntryEventStream LWC Enhancements

Currently, the LWC logEntryEventStream uses the emp API to subscribe/display the stream of LogEntryEvent__e platform events, which counts towards your org's daily limit for platform event delivery allocation (the docs for Platform Event Allocations has more details on this limit).

To help mitigate the usage of the org daily limit for platform event daily delivery allocations, this release includes 2 related changes:

  • Added new control "Max Number of Events to Stream" (shown as #1 in the screenshot below) to set the max number of events to deliver to the LWC before the component auto-pauses the stream. A counter of the total number of events streamed for your session has also been added (shown as #2 in the screenshot below), as well as a <lightning-progress-ring> to show the percentage of events to stream before the component auto-pauses itself (shown as #3 in the screenshot below)

    image

  • Resolved Add new LoggerParameter__mdt record to enable/disable logEntryEventStream lwc #488 by adding new LoggerParameter__mdt record EnableLogEntryEventStream - when set to false, the entire component is completely disabled for the entire organization. The buttons on the LWC are hidden, input elements are disabled, and a warning message is displayed:

    image

loggerHomeHeader LWC Enhancements

  • Added plugin information to the header component in 2 places:
    • Added a count of enabled plugins directly below the lightning card's title. This only displays when 1 or more plugins are enabled in your org (not available in the managed package)

      image

    • Added a comma-separated list of enabled plugins to 'Environment Details' button modal. This only displays when 1 or more plugins are enabled in your org (not available in the managed package)

      image

LoggerHomePage FlexiPage Changes

  • Updated the LoggerAdmin dashboard component on the LoggerHomePage FlexiPage to not hide the dashboard on error (controlled by updating the componentInstanceProperties attribute hideOnError to false - shown in App Builder with MS Paint's amazing ⚡ shape in the screenshot below). Previously, if the dashboard had any errors (such as permission issues with the running user), the home page just displayed an unhelpful empty space in place of the dashboard, making it hard to tell if the page had loaded properly or if the dashboard had an error. Now, the dashboard will display either way.

    image

LoggerAdmin Dashboard Changes

  • Removed the XML node <runningUser>test-triqc8kt7jj0@example.com</runningUser> in LoggerAdmin.dashboard-meta.xml that caused problems for orgs that deploy the metadata (instead of using the unlocked or managed packages)
    • This value was from a scratch org used for building the dashboard, and including it in the metadata worked fine when deploying to other scratch orgs & when creating/installing package versions (even though that particular username would not exist in other orgs). However, when deploying Nebula Logger's metadata to production orgs, the deployment would fail due to not being able to find the matching user. Removing the XML node entirely avoids the deployment issue altogether, and seems cleaner than storing a random scratch org username inside of git

More Label Changes

  • Updated the labels for several metadata items to start with "Nebula Logger" (instead of just "Logger") for clarity on what metadata is part of Nebula Logger - this is especially helpful in orgs that deploy the metadata (instead of using the unlocked or managed packages). The changed metadata includes:
    • AnimationRule
    • CustomPermission
    • FlexiPage
    • GlobalValueSet
    • LWCs
    • Permission Sets
    • Visualforce page

Updated Permission Sets

  • Small bugfix from v4.10.6 release - updated the LoggerAdmin & LoggerLogViewer permission sets to add missing Apex class access to LoggerHomeHeaderController

README.md & Pipeline Changes

  • Updated README.md to include the package installation command for the SF CLI (in addition to the SFDX CLI)
  • Updated README.md to use the "classic" commands for SFDX CLI to better support people that are still using older versions of the SFDX CLI
  • Updated the pipeline's pwsh script so it automatically update the package version ID in README.md for the new SF CLI command

…ventStream - when set to false, the buttons on the LWC are hidden, input elements are disabled, and a warning message is displayed
… closely matches the XML returned by the platform
…ule, CustomPermission, FlexiPage, GlobalValueSet, LWCs, VF page
@jongpie jongpie added Type: Enhancement New feature or request Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger labels Jun 6, 2023
@jongpie jongpie force-pushed the feature/summer-23-release branch from 3261eaa to 38fcea0 Compare June 6, 2023 12:25
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org June 6, 2023 12:29 — with GitHub Actions Failure
Copy link
Collaborator

@jamessimone jamessimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t forget the String.join changes!

@jongpie
Copy link
Owner Author

jongpie commented Jun 6, 2023

@jamessimone thanks for the reminder! I.... had already forgot about it! 😅

…t<String> to List<String> - Summer '23 supports iterating over Set<Object> now

Thanks to @jamessimone for the reminder!
@jongpie jongpie force-pushed the feature/summer-23-release branch from a918d9b to 6e32237 Compare June 6, 2023 13:15
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org June 6, 2023 13:18 — with GitHub Actions Failure
…ter.EnableLogEntryEventStream - it's now back to 'true' as default
…LoggerConsole, added missing Apex class access to LoggerHomeHeaderController in LoggerAdmin & LoggerLogViewer perm sets
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org June 11, 2023 13:36 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org June 11, 2023 13:36 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org June 12, 2023 14:54 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org June 12, 2023 14:54 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 12, 2023 15:07 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 12, 2023 15:20 — with GitHub Actions Inactive
actions-user and others added 4 commits June 12, 2023 15:34
…nts to deliver before the component auto-pauses the stream

This helps avoid unintentionally consuming the org's daily limit for platform event delivery allocations
…ard (even when there are errors), removed <runningUser> XML node in LoggerAdmin dashboard
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org June 19, 2023 18:10 — with GitHub Actions Failure
…managed package

One person reported a gack when deploying the metadata from GitHub, so as a precaution, I'm excluding it from the managed package this release
@jongpie jongpie temporarily deployed to Base Scratch Org June 19, 2023 18:40 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org June 19, 2023 18:40 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 19, 2023 18:50 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 19, 2023 19:02 — with GitHub Actions Inactive
@jongpie jongpie marked this pull request as ready for review June 20, 2023 03:37
The docs say its GA, and the metadata installs in my test orgs, but some test orgs don't have the tab at all, and I don't want to risk an upgrade issue
@jongpie jongpie temporarily deployed to Base Scratch Org June 20, 2023 20:06 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org June 20, 2023 20:06 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 20, 2023 20:17 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org June 20, 2023 20:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.59 🎉

Comparison is base (36f7440) 94.94% compared to head (8b6356e) 95.54%.

❗ Current head 8b6356e differs from pull request most recent head 6df8a4f. Consider uploading reports for the commit 6df8a4f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   94.94%   95.54%   +0.59%     
==========================================
  Files          59       48      -11     
  Lines        5994     5045     -949     
  Branches      129        0     -129     
==========================================
- Hits         5691     4820     -871     
+ Misses        298      225      -73     
+ Partials        5        0       -5     
Flag Coverage Δ
Apex 95.54% <100.00%> (+0.04%) ⬆️
LWC ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-logger/core/main/logger-engine/classes/Logger.cls 96.10% <ø> (ø)
...ore/main/configuration/classes/LoggerParameter.cls 100.00% <100.00%> (ø)
...r/core/main/configuration/classes/LoggerPlugin.cls 96.92% <100.00%> (+0.25%) ⬆️
...nagement/classes/LogEntryEventStreamController.cls 100.00% <100.00%> (ø)
...g-management/classes/LogManagementDataSelector.cls 100.00% <100.00%> (+1.00%) ⬆️
...-management/classes/LoggerHomeHeaderController.cls 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jongpie jongpie merged commit a834b5a into main Jun 29, 2023
@jongpie jongpie deleted the feature/summer-23-release branch June 29, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Log Management Items related to the custom objects & Logger Console app Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new LoggerParameter__mdt record to enable/disable logEntryEventStream lwc
3 participants