Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add menu separator and add -h flag #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bgstack15
Copy link

No description provided.

@jonhoo
Copy link
Owner

jonhoo commented Feb 6, 2020

Thanks, those seem like good changes overall!
For the separator though, I think with @ckardaris' changes from #8 the idea was to have an empty entry correspond to a separator though. So I think you can just look for an empty menu string and insert a separator for those?

@jonhoo
Copy link
Owner

jonhoo commented Feb 6, 2020

I think that if empty string becomes separator, there is no need to also have the ----- variant :)

@bgstack15
Copy link
Author

I predict most users will think of "------------" as a separator before they will think of a blank entry. It also provides an easier item to discover when scanning the input string visually. I strongly recommend leaving that option available.

@jonhoo
Copy link
Owner

jonhoo commented Feb 6, 2020

I think it's unlikely that a user will know to use exactly as many - as required. They will have to look for "separator" in the help, at which point learning about the empty string is just as easy as learning about the ---- pattern, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants