Skip to content

Commit

Permalink
Update: Prettier files
Browse files Browse the repository at this point in the history
  • Loading branch information
jonnitto committed Dec 24, 2023
1 parent 2e9d8c1 commit 17d6114
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 42 deletions.
40 changes: 19 additions & 21 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,36 @@

I love to welcome your contributions. There are several ways to help out:

* Create an [issue](https://github.com/jonnitto/Jonnitto.ImagesInARow/issues) on GitHub, if you have found a bug
* Write test cases or provide examples for open bug issues
* Write patches for open bug/feature issues, preferably with test cases included

- Create an [issue](https://github.com/jonnitto/Jonnitto.ImagesInARow/issues) on GitHub, if you have found a bug
- Write test cases or provide examples for open bug issues
- Write patches for open bug/feature issues, preferably with test cases included

There are a few guidelines that I need contributors to follow so that I have a
chance of keeping on top of things.


## Getting Started

* Make sure you have a [GitHub account](https://github.com/signup/free).
* Submit an [issue](https://github.com/jonnitto/Jonnitto.ImagesInARow/issues), assuming one does not already exist.
* Clearly describe the issue including steps to reproduce when it is a bug.
* Make sure you fill in the earliest version that you know has the issue.
* Fork the repository on GitHub.
- Make sure you have a [GitHub account](https://github.com/signup/free).
- Submit an [issue](https://github.com/jonnitto/Jonnitto.ImagesInARow/issues), assuming one does not already exist.
- Clearly describe the issue including steps to reproduce when it is a bug.
- Make sure you fill in the earliest version that you know has the issue.
- Fork the repository on GitHub.

## Making Changes

* Create a topic branch from where you want to base your work.
* This is usually the master branch.
* Only target release branches if you are certain your fix must be on that
- Create a topic branch from where you want to base your work.
- This is usually the master branch.
- Only target release branches if you are certain your fix must be on that
branch.
* To quickly create a topic branch based on master; `git branch
master/my_contribution master` then checkout the new branch with `git
checkout master/my_contribution`. Better avoid working directly on the
- To quickly create a topic branch based on master; `git branch
master/my_contribution master` then checkout the new branch with `git
checkout master/my_contribution`. Better avoid working directly on the
`master` branch, to avoid conflicts if you pull in updates from origin.
* Make commits of logical units.
* Check for unnecessary whitespace with `git diff --check` before committing.
* Use descriptive commit messages and reference the #issue number.
- Make commits of logical units.
- Check for unnecessary whitespace with `git diff --check` before committing.
- Use descriptive commit messages and reference the #issue number.

## Submitting Changes

* Push your changes to a topic branch in your fork of the repository.
* Submit a pull request to the repository
- Push your changes to a topic branch in your fork of the repository.
- Submit a pull request to the repository
14 changes: 9 additions & 5 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
This is a (multiple allowed):
* [x] bug
* [ ] enhancement
* [ ] feature-discussion (RFC)

* Version: EXACT RELEASE VERSION OR COMMIT HASH, HERE.
* Platform/Target and Browser Versions: PLATFORM CLIENT YOU ARE TARGETING SUCH AS macOS, Windows, CORDOVA, IOS, ANDROID, CHROME, ETC.
- [x] bug
- [ ] enhancement
- [ ] feature-discussion (RFC)

- Version: EXACT RELEASE VERSION OR COMMIT HASH, HERE.
- Platform/Target and Browser Versions: PLATFORM CLIENT YOU ARE TARGETING SUCH AS macOS, Windows, CORDOVA, IOS, ANDROID, CHROME, ETC.

### What you did

EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE.

### Expected Behavior

EXPLAIN WHAT IS TO BE EXPECTED, HERE.

### Actual Behavior

EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE.

P.S. Remember, an issue is not the place to ask questions. You can use [Slack](http://slack.neos.io) or [Discuss](https://discuss.neos.io) for that.
Expand Down
20 changes: 10 additions & 10 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ In the interest of fostering an open and welcoming environment, we as contributo

Examples of behavior that contributes to creating a positive environment include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@ class FlatStructureTransformation extends AbstractTransformation
*/
public function isTransformable(NodeData $node)
{
$numberOfChildNodes = $node->getNumberOfChildNodes('Neos.Neos:ContentCollection', $node->getWorkspace(), $node->getDimensions());
return ($numberOfChildNodes > 0);
$numberOfChildNodes = $node->getNumberOfChildNodes(
'Neos.Neos:ContentCollection',
$node->getWorkspace(),
$node->getDimensions()
);
return $numberOfChildNodes > 0;
}

/**
Expand All @@ -31,13 +35,20 @@ public function isTransformable(NodeData $node)
public function execute(NodeData $node)
{
$contentContext = $this->createContentContext('live', []);
$containerNode = $contentContext->getNodeByIdentifier($node->getIdentifier());
$contentCollections = $containerNode->getChildNodes('Neos.Neos:ContentCollection');
$containerNode = $contentContext->getNodeByIdentifier(
$node->getIdentifier()
);
$contentCollections = $containerNode->getChildNodes(
'Neos.Neos:ContentCollection'
);

foreach ($contentCollections as $contentCollection) {
/** @var NodeInterface $contentCollection */
if ($contentCollection->hasChildNodes()) {
$this->moveChildNodes($contentCollection->getChildNodes(), $containerNode);
$this->moveChildNodes(
$contentCollection->getChildNodes(),
$containerNode
);
$contentCollection->remove();
}
}
Expand Down
2 changes: 1 addition & 1 deletion Configuration/Settings.Neos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Neos:
translation:
autoInclude:
Jonnitto.ImagesInARow:
- "NodeTypes/*"
- 'NodeTypes/*'
fusion:
autoInclude:
Jonnitto.ImagesInARow: true

0 comments on commit 17d6114

Please sign in to comment.