Some suggestions #101
Open
Some suggestions #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkamyab
commented
Feb 16, 2022
mkamyab
commented
Feb 16, 2022
| { |
There was a problem hiding this comment.
It is easier to read through if it is formatted properly in JSON form.
mkamyab
commented
Feb 16, 2022
Comment on lines
+1
to
-9
| import os | ||
|
|
||
| import numpy as np | ||
| from numpy import sin, cos, tan, pi, sqrt | ||
| from numpy.core.defchararray import index | ||
| import yaml | ||
| import os | ||
|
|
||
| from collections import OrderedDict | ||
| # import imp | ||
| from numpy import sin, cos, tan, pi, sqrt | ||
|
|
||
| # import welleng.error |
There was a problem hiding this comment.
- Sorted the imports
- Removed
from numpy.core.defchararray import indexsince it wasn't used in the file.
mkamyab
commented
Feb 16, 2022
| mag_defaults={ | ||
| 'b_total': 50_000., | ||
| 'dip': 70., | ||
| 'declination': 0., | ||
| }, | ||
| mag_defaults=None, |
There was a problem hiding this comment.
Initialization of function arguments to mutable objects is not recommended in python. Check "Using mutable objects as default argument values in python" of this page.
mkamyab
commented
Feb 16, 2022
| @@ -444,8 +448,10 @@ def _get_azi_mag_and_true_deg(self): | |||
| def _get_radius(self, radius=None): | |||
| if radius is None: | |||
| self.radius = np.full_like(self.md.astype(float), 0.3048) | |||
|
|
|||
There was a problem hiding this comment.
It is advisable to put an extra line after the if clause.
added 2 commits
February 16, 2022 14:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going over the code I edited some part of the code and thought it would be useful to share it with you.
I'm adding comments throughout the code to explain reasons for the suggestions.