Fastq scripts upgrade #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handle arguments
Updated some error handling, fixed spacing and syntax for Black/Flake8 best practices, removed some py2 legacy compatibility
Black/Flake8 best practices, broke out arg parsing and header formatting to make code more modular and readable
Broke out argument parsing for ease of reading, Black/flake8 best practices, some small changes to sytax like using with() for keeping file open
Removed some py2 compatibility imports, Black/flake8 best practices, large reorganziation to break up the monolithic main function into more servicable sub functions
…ctices Also incorporated error raising rather than just print statements
…or newer python3 conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and re-formatted/re-factored for modern python best practices (following Black and Flake8). Added some documentation and raising errors. Additionally, updated some python2 code styles in a couple scripts!