chore: upgrade svelte, fix (mostly invalid) svelte compiler warnings

josdejong · Oct 22, 2024 · e3bd1b2 · e3bd1b2
1 parent 86a65e2
commit e3bd1b2
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -124,7 +124,7 @@
     "@sveltejs/adapter-auto": "3.2.5",
     "@sveltejs/kit": "2.7.2",
     "@sveltejs/package": "2.3.5",
-    "@sveltejs/vite-plugin-svelte": "4.0.0-next.8",
+    "@sveltejs/vite-plugin-svelte": "4.0.0",
     "@testing-library/jest-dom": "6.6.2",
     "@testing-library/svelte": "5.2.4",
     "@types/cookie": "0.6.0",
@@ -152,7 +152,7 @@
     "rollup-plugin-postcss": "4.0.2",
     "rollup-plugin-svelte": "7.2.2",
     "standard-version": "9.5.0",
-    "svelte": "5.0.4",
+    "svelte": "5.0.5",
     "svelte-check": "4.0.5",
     "svelte-eslint-parser": "0.43.0",
     "svelte-preprocess": "6.0.3",

diff --git a/src/lib/components/JSONEditor.svelte b/src/lib/components/JSONEditor.svelte
@@ -390,7 +390,7 @@
 
         default:
           // We should never reach this default case
-          return exhaustiveGuard(name)
+          exhaustiveGuard(name)
       }
     }
 

diff --git a/src/lib/components/modals/SortModal.svelte b/src/lib/components/modals/SortModal.svelte
@@ -45,6 +45,7 @@
   $: {
     // remember the selected values for the next time we open the SortModal
     // just in memory, not persisted
+    // eslint-disable-next-line svelte/valid-compile
     sortModalStates[stateId] = {
       selectedProperty,
       selectedDirection

diff --git a/src/lib/components/modals/TransformModal.svelte b/src/lib/components/modals/TransformModal.svelte
@@ -154,6 +154,7 @@
   $: {
     // remember the selected values for the next time we open the SortModal
     // just in memory, not persisted
+    // eslint-disable-next-line svelte/valid-compile
     transformModalStates[stateId] = {
       queryOptions,
       query,

diff --git a/src/lib/components/modes/JSONEditorRoot.svelte b/src/lib/components/modes/JSONEditorRoot.svelte
@@ -81,20 +81,23 @@
       type: 'button',
       text: 'text',
       title: `Switch to text mode (current mode: ${mode})`,
+      // eslint-disable-next-line svelte/valid-compile
       className: 'jse-group-button jse-first' + (mode === Mode.text ? ' jse-selected' : ''),
       onClick: () => onChangeMode(Mode.text)
     },
     {
       type: 'button',
       text: 'tree',
       title: `Switch to tree mode (current mode: ${mode})`,
+      // eslint-disable-next-line svelte/valid-compile
       className: 'jse-group-button ' + (mode === Mode.tree ? ' jse-selected' : ''),
       onClick: () => onChangeMode(Mode.tree)
     },
     {
       type: 'button',
       text: 'table',
       title: `Switch to table mode (current mode: ${mode})`,
+      // eslint-disable-next-line svelte/valid-compile
       className: 'jse-group-button jse-last' + (mode === Mode.table ? ' jse-selected' : ''),
       onClick: () => onChangeMode(Mode.table)
     }

diff --git a/src/lib/components/modes/tablemode/ColumnHeader.svelte b/src/lib/components/modes/tablemode/ColumnHeader.svelte
@@ -21,6 +21,8 @@
 
   $: sortDirection =
     sortedColumn && isEqual(path, sortedColumn?.path) ? sortedColumn.sortDirection : undefined
+
+  // eslint-disable-next-line svelte/valid-compile
   $: sortDirectionName = sortDirection ? SORT_DIRECTION_NAMES[sortDirection] : undefined
 
   function handleSort() {

diff --git a/src/lib/components/modes/tablemode/TableMode.svelte b/src/lib/components/modes/tablemode/TableMode.svelte
@@ -369,6 +369,7 @@
 
   let context: JSONEditorContext
   $: context = {
+    // eslint-disable-next-line svelte/valid-compile
     mode: Mode.table,
     readOnly,
     parser,

diff --git a/src/lib/components/modes/treemode/TreeMode.svelte b/src/lib/components/modes/treemode/TreeMode.svelte
@@ -1810,6 +1810,7 @@
   // it should only change when a config option like readOnly or onClassName is changed
   let context: TreeModeContext
   $: context = {
+    // eslint-disable-next-line svelte/valid-compile
     mode: Mode.tree,
     readOnly,
     parser,