chore: refactor KeySelection
and ValueSelection
#463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, see #460, #454
This PR changes:
into:
Breaking changes:
KeySelection
andValueSelection
are changedcreateKeySelection
andcreateValueSelection
are changed (argumentedit
is removed), and two new helper functions are added:createEditKeySelection
andcreateEditValueSelection
EditableValue
is changedMotivation:
insertActiveElementContents
,tick2
,refreshEditableDiv
, attaching a.refresh()
method to the editable div.edit
), make use of the commonly used helper functionscreateKeySelection
andcreateValueSelection
more compact.