Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select & Native select #270

Merged
merged 21 commits into from
Feb 21, 2024
Merged

Select & Native select #270

merged 21 commits into from
Feb 21, 2024

Conversation

josemarluedke
Copy link
Owner

@josemarluedke josemarluedke commented Feb 19, 2024

image

required

  • Implement scroll
  • update docs for popover controlled
  • add tests for popover controlled
  • tests

follow up (part of larger refactor)

  • integrate into forms pkg
  • docs

nice to have (probably as follow up)

  • loading state
  • ability to render content for the selected item
  • filter/search
    • no results message
    • optional filter function
  • ability to use Native Select in forms pkg
  • Scroll shadow
  • Groups / Sections
  • Multiple with chips
  • clear button
  • selected item should be scrolled into view

@josemarluedke josemarluedke added the Type: Enhancement New feature or request label Feb 19, 2024
@josemarluedke josemarluedke force-pushed the feat/select branch 2 times, most recently from 5058ca1 to 3749a92 Compare February 19, 2024 15:36
@josemarluedke josemarluedke merged commit c8c3ed0 into main Feb 21, 2024
5 checks passed
@josemarluedke josemarluedke deleted the feat/select branch February 21, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant