Skip to content

Commit

Permalink
loosen _fit! method for CCIPCA, bump version
Browse files Browse the repository at this point in the history
  • Loading branch information
@joshday
joshday committed Sep 10, 2024
1 parent ba04afa commit b99b6cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "OnlineStats"
uuid = "a15396b6-48d5-5d58-9928-6d29437db91e"
version = "1.7.0"
version = "1.7.1"

[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
Expand Down
2 changes: 1 addition & 1 deletion src/stats/pca.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Base.lastindex(o::CCIPCA) = outdim(o)
Base.size(o::CCIPCA) = (indim(o), outdim(o))
@inline outdim(o::CCIPCA) = length(o.lambda)
@inline indim(o::CCIPCA) = length(o.center)
function _fit!(o::CCIPCA, x::Vector{Float64})
function _fit!(o::CCIPCA, x::AbstractVector{<:Real})
if o.indimdet == false
# Now indim is known so we set up accordingly
idim = length(x)
Expand Down

2 comments on commit b99b6cc

@joshday
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/114896

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.7.1 -m "<description of version>" b99b6cccbff4028f3689aa91083cc315eff742a3
git push origin v1.7.1

Please sign in to comment.