-
Notifications
You must be signed in to change notification settings - Fork 103
Added support for object variables. Renamed withUUID to withActionOutput #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thank you so much for your hard work!
Just a few very small requests.
@joshfarrant, I split Commit 667e898 adds |
Fantastic! I’ll look at merging this tomorrow. For some reason trying to import actions from shortcuts-is/actions doesn’t work without the actions.js. I’d have thought it would look for the actions file/directory relative to the module’s ‘main’ (the src directory) but that didn’t seem to work iirc. I might well have missed something with that, so I’m open to input on it. |
I need to add a If you can make the node module to have the
|
Looks great, thanks again for your work on this! I'll take a look at building to the root of the project too 👍 |
Checks
Added Actions (if relevant)
Are you happy to be listed as a contributor in the actions list here?
Yes
Any other information / comments
This pull request is the first of a multi step process that will let Shortcuts JS to handle both simple and extended variables, magic variables and global variables:
Attachment
as base [Done]WFSerialization
as baseAggrandizements
for extended variables:an
Attachment
can have anAggrandizements
property used to define type coercion (e.g. use a variable as Text or Dictionary or File) and to access variable sub-properties (e.g. Dictionary Key, File Extension, Image Size)This step is the only one with a breaking change on how the user has to write a Shortcut:
variable()
help function;actionOutput()
help function.Here's a comparison between the old and new methods: