Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Svelte v4 #183

Closed
wants to merge 2 commits into from
Closed

Upgrade to Svelte v4 #183

wants to merge 2 commits into from

Conversation

celldra
Copy link

@celldra celldra commented Aug 8, 2023

I've upgraded all the packages in the package.json and ran the tests that are in the repository, it has passed all of them.

 ✓ test/localStorageStore.test.ts (15)
   ✓ writable() (1)
     ✓ it works, but raises deprecation warning
   ✓ persisted() (14)
     ✓ uses initial value if nothing in local storage
     ✓ uses existing value if data already in local storage
     ✓ set() (2)
       ✓ replaces old value
       ✓ adds new value
     ✓ update() (2)
       ✓ replaces old value
       ✓ adds new value
     ✓ subscribe() (1)
       ✓ publishes updates
     ✓ handles duplicate stores with the same key
     ✓ handles window.storage event (4)
       ✓ sets storage when key matches
       ✓ sets store to null when value is null
       ✓ doesn't update store when key doesn't match
       ✓ doesn't update store when there are no subscribers
     ✓ allows custom serialize/deserialize functions
     ✓ lets you switch storage type

 Test Files  1 passed (1)
      Tests  15 passed (15)
   Start at  12:23:22
   Duration  704ms (transform 66ms, setup 0ms, collect 54ms, tests 15ms, environment 357ms, prepare 87ms)

Let me know if any extra changes are required, I'm happy to help out.

@celldra celldra mentioned this pull request Aug 8, 2023
@joshnuss
Copy link
Owner

joshnuss commented Aug 8, 2023

Hi @celldra,

I think this package should still support 3.x as well.
Can you set the package version to ^3.48.0 || ^4.12.0?

Also, if you don't mind, can you prefix the commit message with feat:, that will trigger a new npm version when merged.

@joshnuss
Copy link
Owner

joshnuss commented Aug 8, 2023

Or maybe event simpler would be to use a version spec like > 3.48.0

@celldra
Copy link
Author

celldra commented Aug 8, 2023

Yeah, that sounds much better. I'm not to familiar with NPM so I apologise about that. I can make the changes now

@joshnuss joshnuss mentioned this pull request Oct 2, 2023
@joshnuss
Copy link
Owner

joshnuss commented Oct 2, 2023

Resolved in #195

@joshnuss joshnuss closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants