Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time to 0.3.36/fix compilation on Rust 1.80 #36

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

DanNixon
Copy link
Contributor

@DanNixon DanNixon commented Aug 9, 2024

Fixes a compile issue (type annotations needed for Box<_>) on Rust 1.80.

See rust-lang/rust#127343 (and NixOS/nixpkgs#332957).

@joshrotenberg
Copy link
Owner

Hey, thanks for this.

Looks like maybe you forgot to commit the Cargo.toml changes.

Fixes a compile issue (type annotations needed for `Box<_>`) on Rust
1.80
@DanNixon
Copy link
Contributor Author

Looks like maybe you forgot to commit the Cargo.toml changes.

Ah, I just did a cargo update time initially, not even realising it was also a direct dependency.
Fixed now.

@DanNixon
Copy link
Contributor Author

Looking at the CI failure, this seems to be a know issue with the GH pages publish action, the suggestion is that updating the action should fix the issue.

Although, is the intention that a PR should publish the book? That seems like something that should only happen on pushes to main.

@joshrotenberg
Copy link
Owner

Sorry, been offline for a bit. I'll try to fix this and get this merged today.

@joshrotenberg joshrotenberg merged commit 8a37747 into joshrotenberg:main Aug 27, 2024
8 of 9 checks passed
@DanNixon DanNixon deleted the update-time branch August 27, 2024 19:57
@DanNixon
Copy link
Contributor Author

@joshrotenberg cheers.

Would it be possible to have a patch release to avoid having to use a non-tag in nixpkgs?

@joshrotenberg
Copy link
Owner

I'll cut a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants