Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pypandoc.convert_text method, fixes a potential error during setup #493

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

xlucn
Copy link
Contributor

@xlucn xlucn commented Dec 23, 2024

Reference issue

#492

What does you PR implement/fix ?

pypandoc.convert was deprecated and removed in pypandoc. The usage can be replaced with pypandoc.convert_text with no other changes.

@xlucn xlucn changed the title use pypandoc.convert_text method, fixes an error when pypandoc is installed use pypandoc.convert_text method, fixes an potential error during setup Dec 23, 2024
@xlucn xlucn changed the title use pypandoc.convert_text method, fixes an potential error during setup use pypandoc.convert_text method, fixes a potential error during setup Dec 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12466516187

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.737%

Totals Coverage Status
Change from base Build 12379086170: 0.0%
Covered Lines: 4141
Relevant Lines: 4514

💛 - Coveralls

@segasai segasai merged commit 55e80b8 into joshspeagle:master Jan 6, 2025
4 checks passed
@segasai
Copy link
Collaborator

segasai commented Jan 6, 2025

Thanks for the report and fix.
I have in the pipeline the migration to the pyproject.toml based installation, but for the time being this seems like correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants