Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem this change Fixes:
fvg()
andswing_highs_lows()
from the old implementation. The old implementation is cheating and cannot be used in real live trading since it looks into the futureSwingMethodEvaluator
toswing_highs_lows()
. Users can experiment with which evaluator results in the most profits!Quality of life fixes:
smc_test.py
because it takes like 10 mins on my laptop :(swing_highs_lows()
Note: Thank you @joshyattridge this library is dope. I'm glad to help.