Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LookAhead Bias #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wescules
Copy link

Problem this change Fixes:

  1. [Most important] Removes the Lookahead Bias in fvg() and swing_highs_lows() from the old implementation. The old implementation is cheating and cannot be used in real live trading since it looks into the future
  2. Added SwingMethodEvaluator to swing_highs_lows(). Users can experiment with which evaluator results in the most profits!
  3. Cleaned up some code

Quality of life fixes:

  1. added loading bar while running smc_test.py because it takes like 10 mins on my laptop :(
  2. improved performance of swing_highs_lows()
  3. improved quality of the generated gif

Note: Thank you @joshyattridge this library is dope. I'm glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant