Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels work #6

Open
wants to merge 11 commits into
base: implement-bip352-full
Choose a base branch
from
Open

Labels work #6

wants to merge 11 commits into from

Commits on Oct 1, 2024

  1. test: add silent payment to wallet descriptor tests 

    - Always set `internal` to `false` for sp descriptors in `listdescriptors` list
- On `getaddressinfo` for silent payment address, search for scan key among wallet silent payment spkmans
- Return the same silent payment for internal and external use
    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7eeeb53 View commit details
    Browse the repository at this point in the history

  2. test: wallet import rescan for silent payments

    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    cf27cfb View commit details
    Browse the repository at this point in the history

  3. Fix TxoutType::ANCHOR not included in switch

    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a799fa4 View commit details
    Browse the repository at this point in the history

  4. test: Silent Payments RBF

    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6f442fa View commit details
    Browse the repository at this point in the history

  5. rpc/generatetoaddress: Reject Silent Payment addresses

    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    115d59c View commit details
    Browse the repository at this point in the history

  6. Set string for sp outputtype to "silent-payments"

    @Eunovo
    Eunovo committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a427e88 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. wallet: Add silent payment taproot scriptPubKeys to addressbook 

    - Collect found silent payment output labels
- Recreate SPLabel Destination with output label tweak
- Add WitnessV1Taproot destination to AddressBook with the SPLabel Destination's address book label
    @Eunovo
    Eunovo committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    708733f View commit details
    Browse the repository at this point in the history

  2. wallet/rpc: Add silent payment labels support 

    Update the following rpc functions to ignore silent payment destinations in the wallet address book
 - getaddressbylabel
 - getreceivedbylabel
 - listreceivedbylabel
    @Eunovo
    Eunovo committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c445b64 View commit details
    Browse the repository at this point in the history

  3. test: Silent Payment labels

    @Eunovo
    Eunovo committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1df251b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. spdescriptor: Replace maxNumberOfLabels with fAllowLabels

    @Eunovo
    Eunovo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    12ec48a View commit details
    Browse the repository at this point in the history

  2. spscriptpubkeyman: Check that desc allows labels before creating labe… 

    …l destinations
    @Eunovo
    Eunovo committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f3e3357 View commit details
    Browse the repository at this point in the history