Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling orjson to check for api status response #17

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Avoid calling orjson to check for api status response #17

merged 1 commit into from
Jan 24, 2024

Conversation

jpbede
Copy link
Owner

@jpbede jpbede commented Jan 24, 2024

Avoid calling orjson directly, move the check to the __pre_deserialize__ function of the newly introduced base response class.

@jpbede jpbede added enhancement Enhancement of the code, not introducing new features. minor This PR causes a minor version bump in the version number. labels Jan 24, 2024
@jpbede jpbede merged commit 2c28d6e into main Jan 24, 2024
12 checks passed
@jpbede jpbede deleted the avoid-calling-orjson branch January 24, 2024 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement of the code, not introducing new features. minor This PR causes a minor version bump in the version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpbede