test(docs): Add documentation for transferOwnership and IsValidSignature

jpgonzalezra · May 18, 2024 · 4095bee · 4095bee
1 parent 9e6a4b2
commit 4095bee
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/test/SimplePlusAccount.t.sol b/test/SimplePlusAccount.t.sol
@@ -26,6 +26,9 @@ contract SimplePlusAccountTest is AccountTest {
         vm.deal(address(account), 1 << 128);
     }
 
+    /**
+     * transferOwnership test cases
+     */
     function testOwnerCanTransferOwnership() public {
         _transferOwnership(eoaAddress, address(0x100));
     }
@@ -82,6 +85,18 @@ contract SimplePlusAccountTest is AccountTest {
         account.transferOwnership(address(account));
     }
 
+    /**
+     * IsValidSignature test cases
+     */
+    function testIsValidSignatureForEoaOwner() public view {
+        bytes32 message = keccak256("simple_plus_account");
+        bytes memory signature = abi.encodePacked(
+            SimplePlusAccount.SignatureType.EOA,
+            sign(EOA_PRIVATE_KEY, getMessageHash(address(account), abi.encode(message)))
+        );
+        assertEq(account.isValidSignature(message, signature), bytes4(keccak256("isValidSignature(bytes32,bytes)")));
+    }
+
     function _transferOwnership(address currentOwner, address newOwner) internal {
         vm.prank(currentOwner);
         vm.expectEmit(true, true, false, false);
@@ -97,4 +112,4 @@ contract SimplePlusAccountTest is AccountTest {
         emit OwnershipTransferred(eoaAddress, address(0x100));
         entryPoint.handleOps(ops, BENEFICIARY);
     }
-}
+}