Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ag grid header text color when column menu is open #3886

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

origami-z
Copy link
Contributor

Go to any ag grid story, open one of column menu by clicking triple dot on header, hover over the cell to see no header cell color flicking

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 9:56am

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 0e60147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@origami-z origami-z changed the title Fix header text color when column menu is open Fix ag grid header text color when column menu is open Aug 2, 2024
@origami-z origami-z self-assigned this Aug 2, 2024
@origami-z
Copy link
Contributor Author

Cortado Goal:
To be fixed and released

@joshwooding
Copy link
Contributor

This breaks the checkbox in the first column

image

@origami-z
Copy link
Contributor Author

This breaks the checkbox in the first column

Should be fixed now

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 20, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Aug 20, 2024
@joshwooding joshwooding merged commit ab0215d into main Aug 20, 2024
15 checks passed
@joshwooding joshwooding deleted the column-menu-header-color branch August 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants