Refactor stepper input #3976
Merged
Refactor stepper input #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24257eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@navkaur76 need some design reviews on stepper input. See PR description for more detail |
origami-z
force-pushed
the
refactor-stepper-input
branch
from
9c0c893
to
f509aa3
Compare
Closed
|
@navkaur76 any review feedback? |
navkaur76
previously approved these changes
Sep 27, 2024
Fercas123
previously approved these changes
Sep 27, 2024
origami-z
force-pushed
the
refactor-stepper-input
branch
from
bec0b19
to
b3ce7a0
Compare
joshwooding
reviewed
Sep 27, 2024
joshwooding
reviewed
Sep 27, 2024
packages/lab/src/stepper-input/internal/useActivateWhileMouseDown.ts
Outdated
Show resolved
Hide resolved
…s the value. Also changed block keys to shift + up/down, and block value to be explicit not a multiplier.
origami-z
force-pushed
the
refactor-stepper-input
branch
from
9411d11
to
24257eb
Compare
Fercas123
approved these changes
Sep 30, 2024
origami-z
added
the
chromatic
github-actions
bot
removed
the
chromatic
navkaur76
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No site doc in this PR, will be in #3586
Inputcomponent, which causes the props to be inconsistent (e.g. needingInputProps.inputProps)border-strong(suggested in Stepper Input theme next style #3878)to do ..
#1855, #3878