Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: 调用MethodChannel的方法都返回Future #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhance: 调用MethodChannel的方法都返回Future #121

wants to merge 2 commits into from
+16 −16

Conversation

yohom
Copy link

@yohom yohom commented Apr 19, 2021

目前一部分方法没有使用MethodChannel的返回值，导致所有调用都是异步的，无法使用await保证执行顺序。

@AlexV525
Copy link
Contributor

治标不治本，原生没有 result。

@yohom
Copy link
Author

yohom commented Apr 21, 2021

那原生为什么不调result？

@AlexV525
Copy link
Contributor

好问题啊，你怎么不问极光的人呢

@yohom
Copy link
Author

yohom commented Apr 21, 2021

那你是极光的人吗

@AlexV525
Copy link
Contributor

🤣 你怕不是误解了什么。我想表达的意思就是：你的 PR 白 PR 了，因为原生没有 result，你的 future query await 根本保证不了顺序，反而由于没有 result 的原因，所有的 future 都会被阻塞。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yohom @AlexV525