Skip to content

Commit

Permalink
CAF::Process: Deprecate support for executing in a subshell
Browse files Browse the repository at this point in the history
As discussed in quattor#255.
  • Loading branch information
jrha committed Jul 3, 2018
1 parent 9247d08 commit 5f1bd55
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/main/perl/Process.pm
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,10 @@ sub execute
{
my $self = shift;

if ($self->{OPTIONS}->{shell}) {
$self->verbose('DEVELOPER FEEDBACK: Executing process using subshell, this is deprecated and may be removed in a future release.');
}

my @opts = ();
foreach my $k (sort(keys (%{$self->{OPTIONS}}))) {
push (@opts, "$k=$self->{OPTIONS}->{$k}");
Expand Down Expand Up @@ -713,6 +717,8 @@ Suppose you want to add options to your command, dynamically:
=head2 Subshells
This functionality has been deprecated and may be removed in a future release.
Okay, you B<really> want them. You can't live without them. You found
some obscure case that really needs a shell. Here is how to get
it. But please, don't use it without a B<good> reason:
Expand Down

0 comments on commit 5f1bd55

Please sign in to comment.