224: validate PolymorphicModels #225
Conversation
|
i didn't take the time to install PG on my machine, so I couldn't run the tests locally. I do, however, have a similar instance set up in another project, so hopefully I was able to write the specs up correctly. |
|
Lovely thank you! I will merge and release today or tomorrow! I appreciate it, thanks! |
|
OK, I actually installed PG to run the specs locally and figured out my bad reference in the new test. All's passing now! Thanks for the quick replies and all your effort on the gem! |
|
ooh, you even added to the CHANGELOG, thank you! I or you should add credit to @LyricL-Gitster there -- I want to give you credit, plus it's good to show that people other than me are even occasionally contributing code! |
|
Sure thing! Should be good to go |
|
oops, just remebered I forgot to come back to this after I left it with CI still running last week! Sorry! Merging and releasing today! |
|
2.3.1 released with this fix! Thank you very much @LyricL-Gitster |
|
Sure thing! Glad to help. |
Fixes #224