implement isURLCodePoint #59
Conversation
Perhaps you were waiting since it's not a pretty thing to have to implement. I'm doing it for my own purposes, so here's a version in what I think is your style if you want it.
changing single quotes to double quotes
src/url-state-machine.js
Outdated
| function isURLCodePoint(c) { | ||
| return ( | ||
| isASCIIAlphanumeric(c) || | ||
| c === 0x21 || |
There was a problem hiding this comment.
Can you switch these over to use the notation used in the URL spec (that is, use the literal chars, pass them through our conversion p transform). Optionally change it to an array (not sure if that makes copying them off the spec easier)?
changed initial codePoint checks to check literal characters passed through p() function; storing them in array
fixing indentation
|
implemented requested changes-- storing character codePoints into an array first even though this is not the strictest interpretation of of whatwg standard; not sure what preference would be. also, my apologies if i made too many commits or named/described them improperly. i usually work alone so i'm really not experienced working on public-facing open-source projects. thanks for your work on this. |
|
No tests? |
|
@stevenvachon There's no (public) API change in |
|
@stevenvachon i'm not working in Javascript environment; just thought I'd write up the functionality since I was doing a similar implementation. changes were trivial |
Perhaps you were waiting since it's not a pretty thing to have to
implement. I'm doing it for my own purposes, so here's a version in what
I think is your style if you want it.