Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark text/x-component as compressible #285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shuding
Copy link

@shuding shuding commented Feb 15, 2023

According to https://en.wikipedia.org/wiki/HTML_Components and other resources, text/x-component (.htc file) is plain text in XML and also very similar to HTML, and it is compressible.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for your contribution! You cannot modify the db.json file directly, as it is a generated file and changes you make will be overwritten. Please see contribution instructions at https://github.com/jshttp/mime-db#contributing . When you update the custom file, please include the source of your information, which cannot be Wikipedia (for example, you can put in the source that Wikipedia cited for that information).

@dougwilson dougwilson added the pr label Feb 15, 2023
@shuding
Copy link
Author

shuding commented Feb 15, 2023

Hi @dougwilson, I just updated the PR to follow the contributing guidelines with sources added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants