crypto: add ecdsa malleability checks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Jan 31, 2024
Comment on lines
-10
to
+11
| .url = "https://github.com/jsign/zig-eth-secp256k1/archive/refs/tags/v0.1.0-beta-3.tar.gz", | ||
| .hash = "1220fcf062f8ee89b343e1588ac3cc002f37ee3f72841dd7f9493d9c09acad7915a3", | ||
| .url = "https://github.com/jsign/zig-eth-secp256k1/archive/refs/tags/v0.1.0-beta-4.tar.gz", | ||
| .hash = "1220c2dbdc5ddd85906c8858f2046b52870f4fe793e0c9af50b8591d10a3f267e250", |
There was a problem hiding this comment.
I had to do some update in my dep, so updating here.
Comment on lines
+28
to
+36
| pub fn validateSignatureFields(r: u256, s: u256) !void { | ||
| if (r > secp256k1.Secp256k1.order) { | ||
| return error.InvalidR; | ||
| } | ||
| // Malleability check. | ||
| if (s > secp256k1.Secp256k1.order / 2) { | ||
| return error.InvalidS; | ||
| } | ||
| } |
There was a problem hiding this comment.
These are the important checks.
Merged
* types: add receipt structs Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * types/receipt: add logs bloom calculation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * blockchain: add receipt generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed/merged after #20
This PR adds the check to solve the ECDSA malleability problem.