-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django REST Framework's Request.data #302
Conversation
I think we need this change as soon as possible, because most of developers use this package with |
Hey, do we have an ETA on when this will be available? |
Hey @muhammedattif @ronanboiteau would either of you like to fork this repo and add this feature? It looks like the owner has no intention to merge any of these requests. I would do it myself, but I am not that confident with Git. |
UPDATE: Fork published to PyPi: djangorestframework-ratelimit Original comment:
Hey @Tom5421! As a temporary solution you could use the branch git+https://github.com/guestready/django-ratelimit.git@v4.1.0-with-drf-support#egg=django-ratelimit As a more permanent solution we could publish the fork to PyPi as something like |
Thanks for that @ronanboiteau. I agree, a more permeant solution would be great. |
Hey @Tom5421 @muhammedattif! I created the fork djangorestframework-ratelimit and published v1.0.0 to PyPi: https://pypi.org/project/djangorestframework-ratelimit/ It's based on django-ratelimit v4.1.0 and it contains the changes suggested in this pull request + the changes from #301 + various changes related to the package management / documentation. You can check the exact diff here. |
Perfect, thank you for doing this! |
Moved to fork djangorestframework-ratelimit Can be installed from PyPi: https://pypi.org/project/djangorestframework-ratelimit/ |
Maybe we can add support in the package like checking if |
Support rate limiting on the key
data
for use with Django REST Framework'sRequest.data