PDK v2.5.0 update

[jeffbyrnes]

SUMMARY

• Automatically updated via pdk update using PDK v2.5.0
• Clean up Ruby syntax per rubocop

TESTS/SPECS

• Ran pdk validate, works as expected
• Ran pdk test unit, works as expected

[jeffbyrnes]

@jsok some maintenance updates here; some of the gems I’m keeping might not be necessary anymore, but I lack enough knowledge of how they may have been incorporated into puppet-rspec generally, if at all.

[vStone]

I did somewhat the same thing but added a .sync.yml file to make it future proof:

---
Gemfile:
  optional:
    ':development':
      - gem: rspec-json_expectations

spec/spec_helper.rb:
  mock_with: ':rspec'
  spec_overrides: |
    require 'rspec/json_expectations'

This will make sure the Gemfile and spec_helper.rb are automatically updated too.

[jeffbyrnes]

@vStone nice! I’ll add that to this PR.

[jsok]

There's a lot of changes in this PR, would it be possible to break it down into a few smaller ones?
e.g. there's some purely linting related changes, others about spec setup and updates, then there's some drastic CI changes along with what seems to be many file unrelated to this project (probably things specific to your local dev environment).

TBH I'm not on top of PDK so any explanations in the PR description would be a big help too.

I'll be able to review and approve the changes quicker with this approach.

[jeffbyrnes]

@jsok so these all came to be as a result of running pdk update, so my impression is that they’re meant to be done altogether.

That said, looking at it freshly after being away from it for a bit, there’s some things here that clearly shouldn’t be changed. So lemme see what I can do.

[jeffbyrnes]

Re-ran this with PDK v2.5.0, and rebased this.

As for explanations, PDK has a concept of “all modules should include these elements for consistency” and pdk update is how you can bring an existing module up-to-snuff with these conventions.

[jeffbyrnes]

Updated this yet again, and also added @vStone’s suggestion of a .sync.yml.