-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend pipeline for newer versions php #746
Merged
DannyvdSluijs
merged 20 commits into
master
from
Extend-pipeline-for-newer-versions-php
Aug 27, 2024
Merged
Extend pipeline for newer versions php #746
DannyvdSluijs
merged 20 commits into
master
from
Extend-pipeline-for-newer-versions-php
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2024
…licit dependency which is restrictive and doesnt support upcoming PHP versions
Seldaek
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pipeline to include PHP >= 8.0 and no longer include PHP <= 7.1. In addition the PR contains the following changes to have green results.
each()
, see https://www.php.net/manual/en/function.each.php. Which resulted in:void
return types to::setup()
methodsphpspec/prophecy
::setExpectedException()
and@ExpectedException
for::expectException
::assertInternalType()
withassertIs*()
methods::getMock()
with::createMock()
ObjectIterator
icecave/parity
to^3,0
to resolve invocations of deprecated/removed methodeach()