-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat, wip: compound key on spectrum #3
base: feature/auto_pin_handling2
Are you sure you want to change the base?
feat, wip: compound key on spectrum #3
Conversation
…ion to remove numba
What is broken RN?
|
@@ -285,7 +307,9 @@ def drop_missing_values_and_fill_spectra_dataframe( | |||
chunk_size=CHUNK_SIZE_ROWS_FOR_DROP_COLUMNS, columns=column | |||
) | |||
for i, feature in enumerate(file_iterator): | |||
if set(spectra) <= set(column): | |||
if set(spectra) <= set( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ... I should make sure it is and move the check out of the loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The function has IMHO some issues anyway. The name is like a whole sentence and still you don't know what it does exactly. Also the handling of nans/missing values is debatable.
This PR goes off this discussion: wfondrie#132 (comment)
The main purpose is two-fold.
Notably:
I think this should be the last major change, we should get after this a feature freeze and a pre-release. I really want a new release by Feb.